Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress output of cleanup #531

Open
michel-kraemer opened this issue Oct 25, 2020 · 1 comment
Open

Suppress output of cleanup #531

michel-kraemer opened this issue Oct 25, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request proposal

Comments

@michel-kraemer
Copy link

Is your feature request related to a problem? Please describe

We have a large repository with several thousands of files that we regularly update. We clean up the whole repository because the filenames include hashes that change on each update. git rm logs every file deleted which makes the log file very large and possibly takes time.

Describe the solution you'd like

It would be great if there was an option to disable the output of git rm. As far as I can see, you just need to add --quiet here:
https://github.com/peaceiris/actions-gh-pages/blob/main/src/git-utils.ts#L115

This would reduce the size of the log file and also save some time I guess.

Describe alternatives you've considered

We considered the keepFiles option, but as I said, the filenames have hashes so this won't work.

Additional context

--

@peaceiris
Copy link
Owner

Thank you for suggesting this.

Yes. I sometimes think the log of git rm is long, me too. I plan to show the log when the debugging flag is enabled only.

BTW, I doubt hiding the log makes fast the deployment process. I don't know the truth until I measure it actually. Simply, the deleting operation is the bottleneck, I think. Did you try to use force_orphan: true? That option does not have any cleaning up operation. If the option is acceptable in your workflow, It may be faster than the current setting.

@peaceiris peaceiris added the enhancement New feature or request label Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proposal
Projects
None yet
Development

No branches or pull requests

2 participants