Add basic unit-tests #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potherca
commented
May 5, 2025
| @@ -20,13 +20,13 @@ | |||
| "require": { | |||
| "php": "^8.0", | |||
| "ext-mbstring": "*", | |||
| "laminas/laminas-diactoros": "^2.14", | |||
| "laminas/laminas-diactoros": "^3.0", | |||
There was a problem hiding this comment.
@ylebre Not sure whether to go for ^3 or ^v2 | ^v3 here...
There was a problem hiding this comment.
Unless we are sure v3 works for older php versions, we should do 2|3.
ylebre
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds first-draft unit-tests for both classes in this repo.
As can be seen by the build, the tests pass for PHP 8.4 but
composer installfails as the requiredlaminas/laminas-diactorosversion does not support PHP 8.4