Skip to content

Commit 859853b

Browse files
Snowflake V2 Connector - 2.2.0 - Add versioning, improve detecting Primary Key, fix datasets metadata (microsoft#3940)
* FLOW-4100 Improve detecting of table primary key (#4) * FLOW-4393 Provide versioning and version identification for Power Apps Connector (#6) * Add Versioning * fix build * FLOW-4102 Fix datasets metadata endpoint to return correct values (#7) * Bump Snowflake Connector version 2.2.0 (#8) * Snowflake V2 Add apidefinition contact and categories --------- Co-authored-by: Piotr Zalas <127133187+sfc-gh-pzalas@users.noreply.github.com>
1 parent f28cdc2 commit 859853b

18 files changed

+581
-527
lines changed

certified-connectors/Snowflake v2/ConnectorArtifacts/apidefinition.swagger.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"swagger": "2.0",
33
"info": {
4-
"version": "1.1",
4+
"version": "2.2",
55
"title": "Snowflake",
66
"description": "Snowflake Connector allows you to build canvas apps and surface Snowflake data in Virtual Tables, while also enabling faster data processing and analytics compared to traditional solutions. This version fixes support for null values in columns of date and time types.",
77
"contact": {

certified-connectors/Snowflake v2/Contracts/ContractResource.Designer.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

certified-connectors/Snowflake v2/Contracts/ContractResource.resx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
<value>OData query syntax tree has exceeded nodes count limit of '{0}'. Please try to simplify OData query parameters expressions.</value>
122122
</data>
123123
<data name="TableDefaultDisplayName" xml:space="preserve">
124-
<value>Tabel</value>
124+
<value>Table</value>
125125
</data>
126126
<data name="TableDefaultPluralName" xml:space="preserve">
127127
<value>Tables</value>

certified-connectors/Snowflake v2/Contracts/Models/DataSetsMetadataSource.cs

Lines changed: 0 additions & 31 deletions
This file was deleted.

certified-connectors/Snowflake v2/SnowflakeTestApp.Tests/BaseIntegrationTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
using System.Collections.Generic;
33
using System.Linq;
44
using System.Net.Http;
5-
using System.Runtime.CompilerServices;
65
using System.Threading.Tasks;
76
using Microsoft.VisualStudio.TestTools.UnitTesting;
87
using Newtonsoft.Json;

certified-connectors/Snowflake v2/SnowflakeTestApp.Tests/Infrastructure/TestDataSeeder.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ BALANCE NUMBER(10,2) DEFAULT 0.00
3232

3333
private readonly HttpClient _httpClient;
3434
private readonly string _baseUrl;
35-
private readonly string _bearerToken;
3635
private readonly AccessTokenService _accessTokenService;
3736

3837
/// <summary>

certified-connectors/Snowflake v2/SnowflakeTestApp.Tests/Metadata/DataSetsMetadataEndpointIntegrationTest.cs

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1+
using Microsoft.Azure.Connectors.SnowflakeV2Contracts.Models;
2+
using Microsoft.VisualStudio.TestTools.UnitTesting;
3+
using Newtonsoft.Json;
14
using System.Net;
25
using System.Threading.Tasks;
3-
using Microsoft.VisualStudio.TestTools.UnitTesting;
46

57
namespace SnowflakeTestApp.Tests.Metadata
68
{
@@ -34,6 +36,23 @@ public async Task GetDataSetMetadataEndpoint_WithAuth_ReturnsOk()
3436
Assert.IsFalse(string.IsNullOrEmpty(content), "Response content should not be empty");
3537
}
3638

39+
/// <summary>
40+
/// Test the /$metadata.json/{dataset} endpoint with authentication and check that it return correct dataset source
41+
/// </summary>
42+
[TestMethod]
43+
public async Task GetDataSetMetadataEndpoint_WithAuth_ReturnsValidDataSetMetadataSource()
44+
{
45+
var testToken = GetTestToken();
46+
HttpClient.DefaultRequestHeaders.Add("Authorization", $"Bearer {testToken}");
47+
48+
var response = await HttpClient.GetAsync($"{BaseUrl}/$metadata.json/datasets");
49+
50+
Assert.AreEqual(HttpStatusCode.OK, response.StatusCode);
51+
var content = await response.Content.ReadAsStringAsync();
52+
var parsedJson = JsonConvert.DeserializeObject<DataSetsMetadata>(content);
53+
Assert.AreEqual($"{TestData.DefaultSnowflakeHostname},{TestData.DefaultDatabase}", parsedJson.TabularDataSetsMetadata.Source);
54+
}
55+
3756
/// <summary>
3857
/// Test the /$metadata.json/{dataset} endpoint without authentication
3958
/// </summary>

0 commit comments

Comments
 (0)