-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build for MSW #4
Comments
IIRC |
i've submitted a fix for upstream: festvox/flite#84 |
yes it works here. NOTE: i got:
on almost all .c files. every message stops compilation for 3 or 4 sec. But yeah, it works :) |
cool that it works. the other option would be to just patch the upstream-sources on the fly (possibly as part of the build-process), by running the following cmd: sed -e 's|\(#define GLOBALVARDEF\) __declspec(dllexport)|\1|' -i deps/flite/include/flite.h deps/flite/src/synth/flite.c (we could just put that into a script in what do you think? |
the other day I had come to something similar Lucarda/pd-hidraw#2 I think the penalty is not so bad as the flite files are build just one time. If you edit the pd-flite.c all the I think the hack is more simple but I leave this decision to you. |
I'm totally glad that flite comes back to its original repo here. It was in my plans but i did't want to bother. I think once this is settled I'll delete my repo. Here is the best place. :) |
i was going to suggest to make you maintainer of this here repo, so you can keep doing your good work :-) |
Good. I don't have anything on the list for pd-flite but yes add me as maintainer. |
Reopening for myself: When I find time I'll try this right before
To avoid hack: Line 27 in 85f47ba
|
@Lucarda used to patch the flite-sources to allow for the windows builds.
now I have incorporated all of lucardas changes except for the bundled (and patched) libflite, I would like to investigate why the patch was needed in the first place (and if there's a fix that could be upstreamed)
The text was updated successfully, but these errors were encountered: