Skip to content
This repository was archived by the owner on Sep 3, 2021. It is now read-only.

Commit cc596ba

Browse files
authored
Merge pull request Shift3#78 from Shift3/cts-clarify-gitflow
docs(readme): clarify some common issues we've had with applicants
2 parents 7cad802 + 1620e64 commit cc596ba

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

README.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,12 @@ You will begin by creating a fork of this repository to your own Github account.
77
Once you have created your fork, review the Issues labeled `challenge task` [HERE](https://github.com/Shift3/react-challenge-project/issues?q=is%3Aissue+is%3Aopen+label%3A%22challenge+task%22). Shift3's standard for branching is as follows:
88

99
- Maintain a `master` and development (`dev`) branch on your fork
10-
- For each new feature (issue), create a branch based off of your `dev` branch
11-
- Once your feature has been completed, submit a Pull Request from your feature branch to your `dev` branch
12-
- If you have a reviewer on your repository, once your Pull Request has been approved, merge your feature branch back into `dev`
13-
- Otherwise, submit the Pull Request and merge it into your `dev` branch
14-
- Once the work has been completed, create a Pull Request from the working branch to your `master` branch and reference the Issue you are working on. These open PRs will be the final submission which Shift3 will review.
10+
- For each feature/task (Issue), create a new branch based off of your `dev` branch
11+
- Once a task has been completed, create a Pull Request from the working branch to your `master` branch and reference the Issue you are working on. **These open PRs will be the final submission which Shift3 will review.**
1512

1613
Once you are ready to submit your work, send an email to your Shift3 contact with a link to your fork.
1714

18-
Please apply the following Shift3 Standard Practices as you work on this project:
15+
**Please apply the following Shift3 Standard Practices as you work on this project:**
1916
- Each unit of work (Issue) should be completed within its own [branch](https://github.com/Shift3/standards-and-practices/blob/master/standards/branching.md).
2017
- Use Karma-style formatting for your [Git Commit Messages](https://github.com/Shift3/standards-and-practices/blob/master/standards/commits.md).
2118
- Generate a PR for each unit of work (Issue) which is completed. Keep the scope of these PRs as narrow as possible. Try not to create PRs which rely on or contain code from previous PRs unless there is truly a dependency between the two units of work.

0 commit comments

Comments
 (0)