You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 3, 2021. It is now read-only.
Copy file name to clipboardExpand all lines: README.md
+3-6Lines changed: 3 additions & 6 deletions
Original file line number
Diff line number
Diff line change
@@ -7,15 +7,12 @@ You will begin by creating a fork of this repository to your own Github account.
7
7
Once you have created your fork, review the Issues labeled `challenge task`[HERE](https://github.com/Shift3/react-challenge-project/issues?q=is%3Aissue+is%3Aopen+label%3A%22challenge+task%22). Shift3's standard for branching is as follows:
8
8
9
9
- Maintain a `master` and development (`dev`) branch on your fork
10
-
- For each new feature (issue), create a branch based off of your `dev` branch
11
-
- Once your feature has been completed, submit a Pull Request from your feature branch to your `dev` branch
12
-
- If you have a reviewer on your repository, once your Pull Request has been approved, merge your feature branch back into `dev`
13
-
- Otherwise, submit the Pull Request and merge it into your `dev` branch
14
-
- Once the work has been completed, create a Pull Request from the working branch to your `master` branch and reference the Issue you are working on. These open PRs will be the final submission which Shift3 will review.
10
+
- For each feature/task (Issue), create a new branch based off of your `dev` branch
11
+
- Once a task has been completed, create a Pull Request from the working branch to your `master` branch and reference the Issue you are working on. **These open PRs will be the final submission which Shift3 will review.**
15
12
16
13
Once you are ready to submit your work, send an email to your Shift3 contact with a link to your fork.
17
14
18
-
Please apply the following Shift3 Standard Practices as you work on this project:
15
+
**Please apply the following Shift3 Standard Practices as you work on this project:**
19
16
- Each unit of work (Issue) should be completed within its own [branch](https://github.com/Shift3/standards-and-practices/blob/master/standards/branching.md).
20
17
- Use Karma-style formatting for your [Git Commit Messages](https://github.com/Shift3/standards-and-practices/blob/master/standards/commits.md).
21
18
- Generate a PR for each unit of work (Issue) which is completed. Keep the scope of these PRs as narrow as possible. Try not to create PRs which rely on or contain code from previous PRs unless there is truly a dependency between the two units of work.
0 commit comments