LODCM - additional functions

[cristinasewell]

Expected Behavior

The following functions might be something scientist might want for the LODCM:

• tweakX:
  https://github.com/pcdshub/old-hutch-configs/blob/18c7769d66a647ab558ad7ebc34d019fc98fbf48/xpp/blinst/lom.py#L1133
• tweakParallel:
  https://github.com/pcdshub/old-hutch-configs/blob/18c7769d66a647ab558ad7ebc34d019fc98fbf48/xpp/blinst/lom.py#L1165
• setE:
  https://github.com/pcdshub/old-hutch-configs/blob/18c7769d66a647ab558ad7ebc34d019fc98fbf48/xpp/blinst/lom.py#L1197
• waitE: ?
  https://github.com/pcdshub/old-hutch-configs/blob/18c7769d66a647ab558ad7ebc34d019fc98fbf48/xpp/blinst/lom.py#L1126
• others... ?

We might need some more feedback from scientists about other things we should include in the LODCM object after #715 is merged in.

Work on fixing/changing the following suggestions - might need to be split into multiple PRs.

• ENH: Lodcm custom status + energy motors #715 (review) (I think the reviews about OffsetMotor and things related to this object can go in a different PR maybe in Add generalized PseudoPositioner with user offset #748 ?)
• ENH: Lodcm custom status + energy motors #715 (comment)
• ENH: Lodcm custom status + energy motors #715 (comment) (I think this can go in a separate PR if we decide to implement it)

Current Behavior

We don't have those functions.

Note

In the old code we use the get_par('retry_deadband') - which I am not sure what it does yet exactly...
if abs(dx - x) > self.x2.get_par("retry_deadband"):

[ZLLentz]

get_par('retry_deadband')

Was basically a caget of an EPICS PV, $PREFIX.RDBD

According to the motor record manual, this is the "retry deadband" field that says "retry moves if they did not get at least this close to the goal"

[cristinasewell]

Work on these guys here:

#715 (review)
#715 (comment)
#715 (comment)
maybe others

[cristinasewell]

@dlzhu when you get a chance, could you please let us know what other functions you use with LODCM other than the ones mentioned here? (tweakX, tweakParallel, setE, waitE)

I think all these functions I got from here:
https://github.com/pcdshub/old-hutch-configs/blob/18c7769d66a647ab558ad7ebc34d019fc98fbf48/xpp/blinst/lom.py#L1093

Thank you