Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom status prints for HOMS #679

Open
ZLLentz opened this issue Nov 5, 2020 · 4 comments
Open

Custom status prints for HOMS #679

ZLLentz opened this issue Nov 5, 2020 · 4 comments
Assignees

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Nov 5, 2020

Expected Behavior

In [1]: mr1l0_homs
Out[1]: 

MR1L0:HOMS (FEE mirror)
----------
x_up (:MMS:XUP)
----
  position: 200.992
  user_setpoint: 200.93 [um]
  description: Main.M3 / M1L0-Xup
-----
pitch (:MMS:PITCH)
-----
  position: 0.016785
  user_setpoint: 0.0 [urad]
  description: Main.M5 / M1L0-Pitch
  pitch_enc_rms: 0.020405309626012367

Summary:

  • only include x_up and pitch
  • include less than normal motor things
  • add pitch rms

Context

https://docs.google.com/document/d/1dmalnT4xLPWoJESsMHTxzIyzlGCBgTQjGNYwDhU-pzo/edit#heading=h.ylcn31lb55xr

@cristinasewell cristinasewell self-assigned this Nov 17, 2020
@cristinasewell
Copy link
Contributor

cristinasewell commented Nov 18, 2020

I'm having a bit of a trouble deciding were to override the format_status_info for HOMS - or understanding which devices are involved for HOMS.
For the example above, I overrode the status handler for the XOffsetMirror and works fine, but what about the rest? I think we have multiple HOMS devices?

Should I override the status handler for KBOMirror, FFMirror too, and maybe others?

@ZLLentz
Copy link
Member Author

ZLLentz commented Nov 18, 2020

Short answer is I think we need to do it on both OffsetMirror and XOffsetMirror

HOMS = "Hard xray offset mirrors"

OffsetMirror handles the three mirror systems in the XRT between XPP and XCS. These use an older controls scheme than all the other mirrors.

XOffsetMirror handles the mirror systems in the FEE and TMO that we've set up in a way more consistent will all of our other motion infrastructure.

The KBO/FF mirrors are something different but still need some support probably... I suspect the scientist preferences will be exactly the same as for the HOMS

@cristinasewell
Copy link
Contributor

Great, thanks a lot for the explanation above!!
I'll change it for the OffsetMirror and XOffsetMirror in this ticket and for the other two later? or should I override it for all 4 of them in this issue?

@ZLLentz
Copy link
Member Author

ZLLentz commented Nov 18, 2020

Trying to piece together what I know about these...

  • I think that the FFMirror will want exactly the same specifications as the others. It's a focusing mirror but it doesn't have any controls to change the focus, so the knobs look the same as for the offset mirrors.
  • I think that the KBOMirror will also want to see the bender axes- my evidence is that we've taken the initiative to include RMS values for these axes

If it's easy to re-use the same code I say go for it. If not then we can split it up into something else.

@cristinasewell cristinasewell mentioned this issue Nov 18, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants