Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTPS - Use Happi Devices for BtpsSourceStatus #1263

Open
slactjohnson opened this issue Jul 26, 2024 · 1 comment
Open

BTPS - Use Happi Devices for BtpsSourceStatus #1263

slactjohnson opened this issue Jul 26, 2024 · 1 comment

Comments

@slactjohnson
Copy link
Contributor

Current Behavior

The current BtpsSourceStatus uses PVs to create stage components. It might be useful to get these stages from the happi database rather than direct instantiation, as well as the cameras.

ls1 = Cpt(
BtpsSourceStatus,
"LTLHN:LS1:",
source_pos=SourcePosition.ls1,
linear_prefix="LAS:BTS:MCS2:01:m1",
rotary_prefix="LAS:BTS:MCS2:01:m2",
goniometer_prefix="LAS:BTS:MCS2:01:m3",
doc="Source status for LS1 (Bay 1)"
)

Context / environment

We need to update some stages/cameras in the configuration. We have this information tracked in the code, rather than happi.

Suggested Solution

I'm not really sure which method is better; I just wanted to make an issue to track this idea.

@tangkong
Copy link
Contributor

tangkong commented Jul 26, 2024

Having it in Happi let's us pull the device into typhos etc so there's that benefit.

It looks like the only common prefix is the first segment (LTLHN), but that's should make Happi instantiation ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants