configdb whitespace and shellcheck

[KaushikMalapati]

Description

• Removed trailing whitespaced
• Replaced legacy backticks with $() notation
• Quoted these variables - opt_dir, USER, EXP, HUTCH, EXE
• Assigning ret_val2
• Added -r flag to read username
• Removed unused ARGSTR variable

Motivation and Context

How Has This Been Tested?

Interactively, opens the window and gives the same cli output as the last version of this

Where Has This Been Documented?

[KaushikMalapati]

I've tried this my version and latest released with a few different experiements that show runs in their elogs, but it always says there are 0 runs found. Do I need to be on a specific host/environment to see xtc files?

[silkenelson]

This only works for LCLS1 and you need to run it on S3DF - I don't remember if I updated this to work work on S3DF (paths may need to be different etc), so there is a chance it actually does not work. So try on S3DF on a recent XCS or CXI experiment - that has the highest chance of working. My vague recollection is that the last times I used it I change to the correct files in the GUI.

[KaushikMalapati]

I think I found one that works

[silkenelson]

I'll approve this. Looking for data under /reg/d/... is not particularly useful, but that is not part of this cleanup.

[silkenelson]

Looks good. At some point we need to make this do something useful again as well.