Skip to content

Conversation

@ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Jul 11, 2025

Description

The wrapper scripts for iocmanager and imgr have been modified to allow for either the "old" (py2, rhel7) or the "new" (py3, rhel7/rhel9) versions of iocmanager during this transition period.

The intention is to deploy this during the shutdown.

Motivation and Context

This allows people to use the new iocmanager (R3.0.0+) when they are ready.

How Has This Been Tested?

Interactively only
Probably it needs more testing

Where Has This Been Documented?

Here only

@ZLLentz ZLLentz marked this pull request as ready for review July 17, 2025 21:39
@ZLLentz ZLLentz requested a review from a team as a code owner July 17, 2025 21:39
@ZLLentz
Copy link
Member Author

ZLLentz commented Jul 17, 2025

Marking this as ready for review with the intent of merging next week concurrent with the release of iocmanager R3.0.0

@ZLLentz
Copy link
Member Author

ZLLentz commented Jul 21, 2025

I'd appreciate being able to merge this this week so we can try R3.0.0 of iocmanager as the main iocmanager for the tst subnet (and maybe for txi?) @pcdshub/engtools-team

@ZLLentz ZLLentz requested review from a team July 21, 2025 23:44
@KaushikMalapati
Copy link
Contributor

On line 70 in imgr and line 46 in iocmanager, there are old checks for unknown_hutch that I think should be removed because they are not possible to enter anymore

@ZLLentz
Copy link
Member Author

ZLLentz commented Jul 22, 2025

Thank you Kaushik, I'll fix these tomorrow morning. I should have been more careful here.

@KaushikMalapati
Copy link
Contributor

Thank you Kaushik, I'll fix these tomorrow morning. I should have been more careful here.

I think the only problem was the hutch path - this probably worked when you tested it, but it would have always returned false on the check for scripts/gui.sh since the base directory didn't expect and fall through to the R2 handling, which happens to currently be correct since no hutch is using R3.0.0+.

@ZLLentz
Copy link
Member Author

ZLLentz commented Jul 22, 2025

I think I've resolved all the issues above

@ZLLentz
Copy link
Member Author

ZLLentz commented Jul 22, 2025

ok, I think I want to release iocmanager in its current state before lunch so I can move on with my life (and use it for the TXI migration). Even if there are no approvals I'm going to merge this in the next 15-20 minutes or so.

@ZLLentz ZLLentz merged commit 48494a8 into pcdshub:master Jul 22, 2025
2 checks passed
@ZLLentz ZLLentz deleted the enh_iocman_r3 branch July 22, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants