-
Notifications
You must be signed in to change notification settings - Fork 35
ENH: extend iocmanager, imgr wrappers to allow for R3.0.0 #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Marking this as ready for review with the intent of merging next week concurrent with the release of iocmanager R3.0.0 |
|
I'd appreciate being able to merge this this week so we can try R3.0.0 of iocmanager as the main iocmanager for the tst subnet (and maybe for txi?) @pcdshub/engtools-team |
|
On line 70 in imgr and line 46 in iocmanager, there are old checks for unknown_hutch that I think should be removed because they are not possible to enter anymore |
|
Thank you Kaushik, I'll fix these tomorrow morning. I should have been more careful here. |
I think the only problem was the hutch path - this probably worked when you tested it, but it would have always returned false on the check for scripts/gui.sh since the base directory didn't expect and fall through to the R2 handling, which happens to currently be correct since no hutch is using R3.0.0+. |
|
I think I've resolved all the issues above |
|
ok, I think I want to release iocmanager in its current state before lunch so I can move on with my life (and use it for the TXI migration). Even if there are no approvals I'm going to merge this in the next 15-20 minutes or so. |
Description
The wrapper scripts for
iocmanagerandimgrhave been modified to allow for either the "old" (py2, rhel7) or the "new" (py3, rhel7/rhel9) versions ofiocmanagerduring this transition period.The intention is to deploy this during the shutdown.
Motivation and Context
This allows people to use the new
iocmanager(R3.0.0+) when they are ready.How Has This Been Tested?
Interactively only
Probably it needs more testing
Where Has This Been Documented?
Here only