♻️ Refactor VyperDeployer to Allow the Configuration of the Target EVM Version

[zobront]

Edit by @pcaversaccio: We refactor the VyperDeployer to allow the configuration of the EVM version. The VyperDeployer contract now offers two overloaded deployContract functions that allow the configuration of the target EVM version.

---

Original text by @zobront:
If snekmate is installed with forge install pcaversaccio/snekmate in a fresh forge repo, tests will fail because the VyperDeployer's call to create in the assembly block will not properly deploy the contract.

To fix, user just needs to ensure that evm_version = 'shanghai' in their foundry.toml file.

This PR simply adds a warning to the README to make them aware of this.

---

🐶 Cute Animal Picture

[pcaversaccio]

@zobront thanks a lot for this PR. To clarify: the VyperDeployer works as intended, but since version 0.3.8, Vyper defaults to shanghai and since the default evm_version from Foundry is paris, it will revert. Actually, you can adjust the VyperDeployer like that to make it work:

string[] memory cmds = new string[](4);
cmds[0] = "vyper";
cmds[1] = string.concat(path, fileName, ".vy");
cmds[2] = "--evm-version";
cmds[3] = "paris";

Maybe I can adjust the VyperDeployer accordingly and dismiss the warning in the README which might be more confusing. What do you think? So it would look like:

    function deployContract(
        string memory path,
        string memory fileName
        string memory evmVersion
    ) public returns (address) {
        // Create a list of strings with the commands necessary
        // to compile Vyper contracts.
        string[] memory cmds = new string[](4);
        cmds[0] = "vyper";
        cmds[1] = string.concat(path, fileName, ".vy");
        cmds[2] = "--evm-version";
        cmds[3] = evmVersion
}

[zobront]

@pcaversaccio Of course, makes sense that it's due to the Vyper version defaulting to Shanghai.

I like your solution a lot, but wouldn't want to burden everyone who uses deployContract() with entering an EVM version.

I assume you're thinking of adding this as a separate function, so that if they include an EVM version then it'll be included, but otherwise will use the existing function? If that's the case, I think that's a great solution and can update the PR to reflect that change.

[pcaversaccio]

@pcaversaccio Of course, makes sense that it's due to the Vyper version defaulting to Shanghai.

I like your solution a lot, but wouldn't want to burden everyone who uses deployContract() with entering an EVM version.

I assume you're thinking of adding this as a separate function, so that if they include an EVM version then it'll be included, but otherwise will use the existing function? If that's the case, I think that's a great solution and can update the PR to reflect that change.

I pushed my changes into this PR. I simply use an overloading strategy to provide this convenience. Lmk if you agree with this approach.

[zobront]

Looks great to me, love the solution 🔥

[pcaversaccio]

Did some final cleanups (removed unnecessary return statements as we use named returns and used calldata instead of memory for the function arguments). Will merged once the CI passed.