Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Remove increase_allowance and decrease_allowance from ERC20 and ERC4626 #159

Closed
pcaversaccio opened this issue Sep 8, 2023 · 0 comments · Fixed by #160
Closed

♻️ Remove increase_allowance and decrease_allowance from ERC20 and ERC4626 #159

pcaversaccio opened this issue Sep 8, 2023 · 0 comments · Fixed by #160
Assignees
@pcaversaccio
Labels
good first issue 🎉 Good for newcomers refactor/cleanup ♻️ Code refactorings and cleanups
Milestone
0.0.3

Comments

@pcaversaccio
Copy link
Owner

pcaversaccio commented Sep 8, 2023 •
edited
Loading

See OpenZeppelin/openzeppelin-contracts#4583. We should remove the functions increase_allowance and decrease_allowance from the ERC20 and ERC4626 contracts as they only solve an imaginary problem and could be used to bypass spending restrictions in smart contract wallets. The reason I added it firsthand was to be consistent with the OpenZeppelin/Solady implementations to avoid any confusion. The PR that implements this change requires a CHANGELOG entry.
@pcaversaccio pcaversaccio added the good first issue 🎉 Good for newcomers label Sep 8, 2023
@pcaversaccio pcaversaccio added this to the 0.0.3 milestone Sep 8, 2023
@pcaversaccio pcaversaccio self-assigned this Sep 8, 2023
@pcaversaccio pcaversaccio added the refactor/cleanup ♻️ Code refactorings and cleanups label Sep 8, 2023
@ControlCplusControlV ControlCplusControlV mentioned this issue Sep 8, 2023
Merged
@pcaversaccio pcaversaccio linked a pull request Sep 8, 2023 that will close this issue
♻️ Remove increase_allowance and decrease_allowance from ERC20 and ERC4626 #160
Merged
@pcaversaccio pcaversaccio changed the title 💥 Remove increase_allowance and decrease_allowance from ERC20 and ERC4626 ♻️ Remove increase_allowance and decrease_allowance from ERC20 and ERC4626 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcaversaccio pcaversaccio

Labels
good first issue 🎉 Good for newcomers refactor/cleanup ♻️ Code refactorings and cleanups
Projects
None yet
Milestone
0.0.3
1 participant
@pcaversaccio