Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle headers for integer types with precision cascades #21

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Handle headers for integer types with precision cascades #21

merged 3 commits into from
Sep 2, 2022

Conversation

genevb
Copy link

@genevb genevb commented Sep 2, 2022

Blast does not provide the precision cascade functionality to integer-types, and they are appropriately differentiated from real-type data in core/accelogic/src/ZipAccelogic.cxx. In principle, the cascade settings should be irrelevant for such types, but the tasks for setting up a precision cascade are done without any check on the data type, so the TBranchPrecisionCascade objects and cascade files are all done before ZipAccelogic's functionality is called. It is simpler to make sure those objects are properly handled for this case than it is to put in the logic to avoid setting up the TBranchPrecisionCascade objects for integer types, even though the latter might seem "cleaner" from a user perspective.

To that end, even if a TBranchPrecisionCascade is generated for such types, the information in the auxiliary cascade tiers should be unimportant. But headers are necessary for these objects to make sense, and presently there is an attempt to read the headers but they don't make sense. This commit achieves the desired result, with appropriate headers indicating that there is no actual content in the auxiliary tiers.

I have done some testing, including reading back with and without the auxiliary files demonstrating that they are in fact inconsequential for the readback.

@genevb genevb requested a review from pcanal as a code owner September 2, 2022 20:29
@pcanal pcanal merged commit 2941d75 into pcanal:AccelogicMain Sep 2, 2022
@pcanal
Copy link
Owner

pcanal commented Sep 2, 2022

thanks.

@genevb genevb deleted the ZIGTest branch September 2, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants