Skip to content

Commit dfbdfcd

Browse files
committed
renaming JSONEventLayout to JSONEventLayoutV0
1 parent 476ffd5 commit dfbdfcd

File tree

5 files changed

+12
-15
lines changed

5 files changed

+12
-15
lines changed

src/main/java/net/logstash/log4j/JSONEventLayout.java renamed to src/main/java/net/logstash/log4j/JSONEventLayoutV0.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,11 @@
99
import org.apache.log4j.spi.LoggingEvent;
1010
import org.apache.log4j.spi.ThrowableInformation;
1111

12-
import java.util.Date;
1312
import java.util.HashMap;
1413
import java.util.Map;
1514
import java.util.TimeZone;
1615

17-
public class JSONEventLayout extends Layout {
16+
public class JSONEventLayoutV0 extends Layout {
1817

1918
private boolean locationInfo = false;
2019

@@ -44,7 +43,7 @@ public static String dateFormat(long timestamp) {
4443
* For backwards compatibility, the default is to generate location information
4544
* in the log messages.
4645
*/
47-
public JSONEventLayout() {
46+
public JSONEventLayoutV0() {
4847
this(true);
4948
}
5049

@@ -53,7 +52,7 @@ public JSONEventLayout() {
5352
*
5453
* @param locationInfo whether or not to include location information in the log messages.
5554
*/
56-
public JSONEventLayout(boolean locationInfo) {
55+
public JSONEventLayoutV0(boolean locationInfo) {
5756
this.locationInfo = locationInfo;
5857
}
5958

src/test/java/net/logstash/log4j/JSONEventLayoutTest.java renamed to src/test/java/net/logstash/log4j/JSONEventLayoutV0Test.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@
66
import org.apache.log4j.Level;
77
import org.apache.log4j.Logger;
88
import org.apache.log4j.NDC;
9-
import org.junit.Before;
109
import org.junit.After;
11-
import org.junit.AfterClass;
1210
import org.junit.BeforeClass;
1311
import org.junit.Ignore;
1412
import org.junit.Test;
@@ -20,9 +18,9 @@
2018
* Time: 12:07 AM
2119
* To change this template use File | Settings | File Templates.
2220
*/
23-
public class JSONEventLayoutTest {
21+
public class JSONEventLayoutV0Test {
2422
static Logger logger;
25-
static MockAppender appender;
23+
static MockAppenderV0 appender;
2624
static final String[] logstashFields = new String[]{
2725
"@message",
2826
"@source_host",
@@ -32,7 +30,7 @@ public class JSONEventLayoutTest {
3230

3331
@BeforeClass
3432
public static void setupTestAppender() {
35-
appender = new MockAppender(new JSONEventLayout());
33+
appender = new MockAppenderV0(new JSONEventLayoutV0());
3634
logger = Logger.getRootLogger();
3735
appender.setThreshold(Level.TRACE);
3836
appender.setName("mockappender");
@@ -148,7 +146,7 @@ public void testJSONEventHasThreadName() {
148146

149147
@Test
150148
public void testJSONEventLayoutNoLocationInfo() {
151-
JSONEventLayout layout = (JSONEventLayout) appender.getLayout();
149+
JSONEventLayoutV0 layout = (JSONEventLayoutV0) appender.getLayout();
152150
boolean prevLocationInfo = layout.getLocationInfo();
153151

154152
layout.setLocationInfo(false);
@@ -171,7 +169,7 @@ public void testJSONEventLayoutNoLocationInfo() {
171169
@Test
172170
@Ignore
173171
public void measureJSONEventLayoutLocationInfoPerformance() {
174-
JSONEventLayout layout = (JSONEventLayout) appender.getLayout();
172+
JSONEventLayoutV0 layout = (JSONEventLayoutV0) appender.getLayout();
175173
boolean locationInfo = layout.getLocationInfo();
176174
int iterations = 100000;
177175
long start, stop;
@@ -201,6 +199,6 @@ public void measureJSONEventLayoutLocationInfoPerformance() {
201199
@Test
202200
public void testDateFormat() {
203201
long timestamp = 1364844991207L;
204-
Assert.assertEquals("format does not produce expected output", "2013-04-01T19:36:31.207Z", JSONEventLayout.dateFormat(timestamp));
202+
Assert.assertEquals("format does not produce expected output", "2013-04-01T19:36:31.207Z", JSONEventLayoutV0.dateFormat(timestamp));
205203
}
206204
}

src/test/java/net/logstash/log4j/JSONEventV1LayoutTest.java renamed to src/test/java/net/logstash/log4j/JSONEventLayoutV1Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
* Time: 12:07 AM
2121
* To change this template use File | Settings | File Templates.
2222
*/
23-
public class JSONEventV1LayoutTest {
23+
public class JSONEventLayoutV1Test {
2424
static Logger logger;
2525
static MockAppenderV1 appender;
2626
static final String[] logstashFields = new String[]{

src/test/java/net/logstash/log4j/MockAppender.java renamed to src/test/java/net/logstash/log4j/MockAppenderV0.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
import org.apache.log4j.spi.LoggingEvent;
88
import org.apache.log4j.Layout;
99

10-
public class MockAppender extends AppenderSkeleton {
10+
public class MockAppenderV0 extends AppenderSkeleton {
1111

1212
private static List messages = new ArrayList();
1313

14-
public MockAppender(Layout layout){
14+
public MockAppenderV0(Layout layout){
1515
this.layout = layout;
1616
}
1717
@Override

0 commit comments

Comments
 (0)