fixed build issue

Author: daveshanley

datamodel/high/node_builder.go

@@ -176,50 +176,52 @@ func (n *NodeBuilder) add(key string, i int) {
 		nodeEntry.Value = f
 	}
 
-	// if there is no low level object, then we cannot extract line numbers,
+	// if there is no low-level object, then we cannot extract line numbers,
 	// so skip and default to 0, which means a new entry to the spec.
 	// this will place new content and the top of the rendered object.
 	if n.Low != nil && !reflect.ValueOf(n.Low).IsZero() {
 		lowFieldValue := reflect.ValueOf(n.Low).Elem().FieldByName(key)
-		fLow := lowFieldValue.Interface()
-		value = reflect.ValueOf(fLow)
-
-		nodeEntry.LowValue = fLow
-		switch value.Kind() {
-
-		case reflect.Slice:
-			l := value.Len()
-			lines := make([]int, l)
-			for g := 0; g < l; g++ {
-				qw := value.Index(g).Interface()
-				if we, wok := qw.(low.HasKeyNode); wok {
-					lines[g] = we.GetKeyNode().Line
-				}
-			}
-			sort.Slice(lines, func(i, j int) bool {
-				return lines[i] < lines[j]
-			})
-			if len(lines) > 0 {
-				nodeEntry.Line = lines[0]
-			}
-		case reflect.Struct:
-			y := value.Interface()
-			nodeEntry.Line = 9999 + i
-			if nb, ok := y.(low.HasValueNodeUntyped); ok {
-				if nb.IsReference() {
-					if jk, kj := y.(low.HasKeyNode); kj {
-						nodeEntry.Line = jk.GetKeyNode().Line
-						break
+		if lowFieldValue.IsValid() {
+			fLow := lowFieldValue.Interface()
+			value = reflect.ValueOf(fLow)
+
+			nodeEntry.LowValue = fLow
+			switch value.Kind() {
+
+			case reflect.Slice:
+				l := value.Len()
+				lines := make([]int, l)
+				for g := 0; g < l; g++ {
+					qw := value.Index(g).Interface()
+					if we, wok := qw.(low.HasKeyNode); wok {
+						lines[g] = we.GetKeyNode().Line
 					}
 				}
-				if nb.GetValueNode() != nil {
-					nodeEntry.Line = nb.GetValueNode().Line
+				sort.Slice(lines, func(i, j int) bool {
+					return lines[i] < lines[j]
+				})
+				if len(lines) > 0 {
+					nodeEntry.Line = lines[0]
+				}
+			case reflect.Struct:
+				y := value.Interface()
+				nodeEntry.Line = 9999 + i
+				if nb, ok := y.(low.HasValueNodeUntyped); ok {
+					if nb.IsReference() {
+						if jk, kj := y.(low.HasKeyNode); kj {
+							nodeEntry.Line = jk.GetKeyNode().Line
+							break
+						}
+					}
+					if nb.GetValueNode() != nil {
+						nodeEntry.Line = nb.GetValueNode().Line
+					}
 				}
+			default:
+				// everything else, weight it to the bottom of the rendered object.
+				// this is things that we have no way of knowing where they should be placed.
+				nodeEntry.Line = 9999 + i
 			}
-		default:
-			// everything else, weight it to the bottom of the rendered object.
-			// this is things that we have no way of knowing where they should be placed.
-			nodeEntry.Line = 9999 + i
 		}
 	}
 	if nodeEntry.Value != nil {

datamodel/high/node_builder_test.go

@@ -85,7 +85,6 @@ type test1 struct {
 	Thunk      valueReferenceStruct                              `yaml:"thunk,omitempty"`
 	Thrim      *valueReferenceStruct                             `yaml:"thrim,omitempty"`
 	Thril      *orderedmap.Map[string, *valueReferenceStruct]    `yaml:"thril,omitempty"`
-	Thryp      string                                            `yaml:"description"`
 	Extensions *orderedmap.Map[string, *yaml.Node]               `yaml:"-"`
 	ignoreMe   string                                            `yaml:"-"`
 	IgnoreMe   string                                            `yaml:"-"`
@@ -1143,8 +1142,10 @@ func TestNewNodeBuilder_Int64_Negative(t *testing.T) {
 }
 
 func TestNewNodeBuilder_DescriptionOmitEmpty(t *testing.T) {
-	t1 := test1{
-		Thryp: "",
+	t1 := struct {
+		Blah string `yaml:"description"`
+	}{
+		Blah: "",
 	}
 
 	nb := NewNodeBuilder(&t1, &t1)