Merge pull request #16 from gregjopa/negative-testing-improvements

Improve support for negative testing

Author: devpato

index.html

@@ -88,7 +88,10 @@
                 throw new Error(
                   `${errorDetail.description} (${orderData.debug_id})`,
                 );
-              } else {
+              } else if (!orderData.purchase_units) {
+                throw new Error(JSON.stringify(orderData));
+              }
+              else {
                 // (3) Successful transaction -> Show confirmation or thank you message
                 // Or go to another URL:  actions.redirect('thank_you.html');
                 const transaction =

server.js

@@ -66,6 +66,11 @@ const createOrder = async (cart) => {
     headers: {
       'Content-Type': 'application/json',
       Authorization: `Bearer ${accessToken}`,
+      // Uncomment one of these to force an error for negative testing (in sandbox mode only). Documentation:
+      // https://developer.paypal.com/tools/sandbox/negative-testing/request-headers/
+      // "PayPal-Mock-Response": '{"mock_application_codes": "MISSING_REQUIRED_PARAMETER"}'
+      // "PayPal-Mock-Response": '{"mock_application_codes": "PERMISSION_DENIED"}'
+      // "PayPal-Mock-Response": '{"mock_application_codes": "INTERNAL_SERVER_ERROR"}'
     },
     method: 'POST',
     body: JSON.stringify(payload),
@@ -91,22 +96,24 @@ const captureOrder = async (orderID) => {
       // https://developer.paypal.com/tools/sandbox/negative-testing/request-headers/
       // "PayPal-Mock-Response": '{"mock_application_codes": "INSTRUMENT_DECLINED"}'
       // "PayPal-Mock-Response": '{"mock_application_codes": "TRANSACTION_REFUSED"}'
+      // "PayPal-Mock-Response": '{"mock_application_codes": "INTERNAL_SERVER_ERROR"}'
     },
   });
 
   return handleResponse(response);
 };
 
 async function handleResponse(response) {
-  if (response.status === 500 || response.status === 503) {
+  try {
+    const jsonResponse = await response.json();
+    return {
+      jsonResponse,
+      httpStatusCode: response.status,
+    };
+  } catch (err) {
     const errorMessage = await response.text();
     throw new Error(errorMessage);
   }
-
-  return {
-    jsonResponse: await response.json(),
-    httpStatusCode: response.status,
-  };
 }
 
 app.post('/api/orders', async (req, res) => {