fix: telemetry in opennext cloudflare #12327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would somebody from Payload be able to take a look at this? |
paulpopus
approved these changes
May 20, 2025
|
Thank you so much for these PRs! We'll get these merged soon! |
|
🚀 This is included in version v3.39.0 |
paulpopus
pushed a commit
that referenced
this pull request
May 23, 2025
### What? Fixes an infinite loop that may occur when invoking the findUp() utility to search for a file by name and no result is found. ### Why? If triggered, the infinite loop will hang the entire application. For example, this occurs when trying to boot Payload from a Cloudflare Worker, as reported in #12327 ### How? By checking whether it has reached the root directory before analysing the parent folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR help to fix an issue you'll encounter while running payload in OpenNext on cloudflare
Why?
Sending telemetry event will create an infinite loop because it won't be able to find a
package.jsonHow?
Putting the whole logic of
sendEventbehindconfig.telemetryallows to disable it and thus, make it work on cloudflareSee this comment for more info : opennextjs/opennextjs-cloudflare#263 (comment)