Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Boost 1.87.0 (Boost.Asio removals) #1027

Open
cho-m opened this issue Nov 28, 2024 · 1 comment
Open

Add support for Boost 1.87.0 (Boost.Asio removals) #1027

cho-m opened this issue Nov 28, 2024 · 1 comment

Comments

@cho-m
Copy link
Contributor

cho-m commented Nov 28, 2024

  • Your operating system name and version?

Tested on Homebrew CI so macOS 13-15 and Linux Ubuntu 22.04

  • Please attach your /etc/fastnetmon.conf configuration file
  • What capture engine are you using: Netflow, sFlow, miror?
  • If you are using Netflow or sFlow, please specify version, vendor name, model name and firmware of agent device.
  • Please attach /var/log/fastnetmon.log

N/A as related to compilation rather than running.


Advance notice that FastNetMon does not compile with upcoming Boost 1.87.0 (based on beta1) as Boost.Asio has removed the deprecated io_service boostorg/asio@ec0908c

This causes errors like:

fastnetmon-1.2.7/src/fast_library.cpp:1090:22: error: no type named 'io_service' in namespace 'boost::asio'
 1090 |         boost::asio::io_service io_service;
      |         ~~~~~~~~~~~~~^

Also need to remove boost::asio::ip::tcp::resolver::query and change code as described in https://www.boost.org/doc/libs/1_86_0/doc/html/boost_asio/net_ts.html

boost::asio::io_service io_service;
boost::asio::ip::tcp::resolver resolver(io_service);
boost::asio::ip::tcp::resolver::query query(domain_name, "");
for (boost::asio::ip::tcp::resolver::iterator i = resolver.resolve(query);

Easiest option is to require a minimum of Boost 1.66.0 (boostorg/asio@b60e92b) and update APIs, which may be possible as code already uses io_context:

boost::asio::io_context ioc;

@cho-m cho-m changed the title Add support for upcoming Boost 1.87.0 (Boost.Asio removals) Add support for Boost 1.87.0 (Boost.Asio removals) Dec 13, 2024
@pavel-odintsov
Copy link
Owner

Hello!

Thank you very much for reporting this issue! I'll look on it shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants