-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can you update jade version? #15
Comments
Hi @Krekotun. I think #13 would achieve that, where I've outlined some things we need to figure out first. My understanding is that In #13 I mentioned that I'd like to allow consumers to be able to provide their own version of Jade so that they're not bound to any particular version beyond their control. |
@paulyoung it would be awesome to add some tests in repo, so you/consumer will see if new version of jade is breaking something.
Do you have any ideas how to make this? |
@Krekotun instead of: var JadeInheritance = require('jade-inheritance');
var inheritance = new JadeInheritance('foo.jade'); something like: var jade = require("jade");
var JadeInheritance = require('jade-inheritance');
var inheritance = new JadeInheritance(jade, 'foo.jade'); |
@paulyoung nice, how soon do you plan to implements this? |
Huy guys, I use gulp-jade-inheritance but jade is used here differs from gulp-jade (1.11). I also want to use code blocks, like
but jade 1.9 fails. How to solve it? |
I just updated package.json to "jade": "^1.11.0" and ran "npm -i" and code blocks now works. |
Is there an actual fix? I updated the version of Jade in our package.json but it is not working. Only way i found was to use npm-shrinkwrap. |
Hmm, I changed nothing except the version and I have everything working. |
Having the same problem using "gulp-jade": "^1.1.0" as it is the last version. Getting error on jade code blocks like that
Error: unexpected text -\n src\test.jade\n at Object.Lexer.fail |
The issue is with your package.json. Check it, it must work |
salex772, thanks! I changed the version of jade in jade-inheritance as you recommended here issue 14 and it works now! |
Hi, current version of jade is 1.11. It includes feature 'block code support' and a lot of improvements.
Can you update version in package.json?
The text was updated successfully, but these errors were encountered: