BUGFIXES:

1 After changes in ramp gene generic attribute - static pulse tb reported error - fix now
2 Max Min Mean test bench had few problems when passing integer with exponent, removed generic with exponent as full integer

Author: BenoitStef

hdl/psi_common_pulse_generator_ctrl_static.vhd

@@ -91,8 +91,10 @@ begin
   --*** Pulse generator ***  
   inst_pulse : entity work.psi_common_ramp_gene
     generic map(
-      width_g   => length_g,
-      rst_pol_g => rst_pol_g)
+      width_g     => length_g,
+      is_sign_g   => false,
+      rst_pol_g   => rst_pol_g,
+      init_val_g  => 0)
     port map(
       clk_i      => clk_i,
       rst_i      => rst_i,

sim/config.tcl

@@ -162,7 +162,7 @@ tb_run_add_arguments \
   "-gclock_cycle_g=100 -gsigned_data_g=true -gdata_length_g=16 -gaccu_length_g=64" \
   "-gclock_cycle_g=10 -gsigned_data_g=false -gdata_length_g=8 -gaccu_length_g=16" \
   "-gclock_cycle_g=10 -gsigned_data_g=true -gdata_length_g=24 -gaccu_length_g=48" \
-  "-gclock_cycle_g=10 -gsigned_data_g=false -gdata_length_g=32 -gaccu_length_g=40"
+  "-gclock_cycle_g=10 -gsigned_data_g=false -gdata_length_g=31 -gaccu_length_g=40"
 add_tb_run
 
 create_tb_run "psi_common_find_min_max_tb"
@@ -185,9 +185,9 @@ add_tb_run
 
 create_tb_run "psi_common_pulse_generator_ctrl_static_tb"
 tb_run_add_arguments \
-	"-glength_g=16 -gfreq_clk_g=100e6 -gstr_freq_g=12e6 -gstep_dw_g=5 -gstep_up_g=10 -gstep_fll_g=50 -gstep_flh_g=60"\
-	"-glength_g=16 -gfreq_clk_g=100e6 -gstr_freq_g=1e6  -gstep_dw_g=17 -gstep_up_g=29 -gstep_fll_g=301 -gstep_flh_g=400"\
-  "-glength_g=16 -gfreq_clk_g=100e6 -gstr_freq_g=10e6 -gstep_dw_g=129 -gstep_up_g=738 -gstep_fll_g=12302 -gstep_flh_g=8789"
+	"-glength_g=16 -gfreq_clk_g=100000000 -gstr_freq_g=12000000 -gstep_dw_g=5 -gstep_up_g=10 -gstep_fll_g=50 -gstep_flh_g=60"\
+	"-glength_g=16 -gfreq_clk_g=100000000 -gstr_freq_g=1000000  -gstep_dw_g=17 -gstep_up_g=29 -gstep_fll_g=301 -gstep_flh_g=400"\
+  "-glength_g=16 -gfreq_clk_g=100000000 -gstr_freq_g=10000000 -gstep_dw_g=129 -gstep_up_g=738 -gstep_fll_g=12302 -gstep_flh_g=8789"
 add_tb_run
 
 create_tb_run "psi_common_ramp_gene_tb"

testbench/psi_common_min_max_mean_tb/psi_common_min_max_mean_tb.vhd

@@ -43,7 +43,7 @@ architecture tb of psi_common_min_max_mean_tb is
   signal max_s        : std_logic_vector(data_length_g - 1 downto 0) := (others => '0');
   signal counter_s    : integer :=0;
 begin
-
+  assert data_length_g < 32 report "[ERROR]: for this test bench only data length less than 32 are authorized" severity failure;
   --*** Reset generation ***
   proc_rst : process
   begin

testbench/psi_common_pulse_generator_ctrl_static_tb/psi_common_pulse_generator_ctrl_static_tb.vhd

@@ -240,9 +240,9 @@ begin
     trig_sti     <= '1';
     wait for (step_fll_g*200)*(1 sec /str_freq_g);
     stop_sti <= '1';
-     print("[INFO]: pulse ABORT at " & to_string(now, ns));
-    wait until str_obs = '1';
-    wait until str_obs = '1';
+    print("[INFO]: pulse ABORT at " & to_string(now, ns));
+    wait until rising_edge(str_obs);
+    wait until rising_edge(str_obs);
     assert dat_obs =to_uslv(0,length_g) report"[ERROR]: It didn't stop " severity error; 
 
     print(" *********************************************************");