From 09bca095e38d6e4770ae48e174f59d33c862abc2 Mon Sep 17 00:00:00 2001 From: Matheus Marchini Date: Fri, 27 Jul 2018 20:09:39 -0700 Subject: [PATCH] [postmortem] add ScopeInfo and Context types The metadata introduced in this patch will be useful for postmortem tools to inspect Contexts and ScopeInfos (see https://github.com/nodejs/llnode/issues/211). R=bmeurer@google.com, yangguo@google.com Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95 Reviewed-on: https://chromium-review.googlesource.com/1153858 Reviewed-by: Yang Guo Commit-Queue: Yang Guo Cr-Commit-Position: refs/heads/master@{#54768} --- BUILD.gn | 1 + tools/gen-postmortem-metadata.py | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/BUILD.gn b/BUILD.gn index 2e3803a4acd6..74084b63e3f9 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -850,6 +850,7 @@ action("postmortem-metadata") { "src/objects/js-regexp-string-iterator.h", "src/objects/map.h", "src/objects/map-inl.h", + "src/objects/scope-info.h", "src/objects/script.h", "src/objects/script-inl.h", "src/objects/shared-function-info.h", diff --git a/tools/gen-postmortem-metadata.py b/tools/gen-postmortem-metadata.py index d8ef7b4a158a..8191c8152f59 100644 --- a/tools/gen-postmortem-metadata.py +++ b/tools/gen-postmortem-metadata.py @@ -58,6 +58,9 @@ { 'name': 'APIObjectType', 'value': 'JS_API_OBJECT_TYPE' }, { 'name': 'SpecialAPIObjectType', 'value': 'JS_SPECIAL_API_OBJECT_TYPE' }, + { 'name': 'FirstContextType', 'value': 'FIRST_CONTEXT_TYPE' }, + { 'name': 'LastContextType', 'value': 'LAST_CONTEXT_TYPE' }, + { 'name': 'IsNotStringMask', 'value': 'kIsNotStringMask' }, { 'name': 'StringTag', 'value': 'kStringTag' }, @@ -282,7 +285,7 @@ expected_classes = [ 'ConsString', 'FixedArray', 'HeapNumber', 'JSArray', 'JSFunction', 'JSObject', 'JSRegExp', 'JSValue', 'Map', 'Oddball', 'Script', - 'SeqOneByteString', 'SharedFunctionInfo' + 'SeqOneByteString', 'SharedFunctionInfo', 'ScopeInfo' ];