Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TextInputGroup): allow input in basic example #9650

Merged

Conversation

mfrances17
Copy link
Contributor

What: Closes #9588

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Sep 19, 2023

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why yarn file changed here... Otherwise lgtm

Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just discard the yarn.lock as it should not have changed, otherwise LGTM

@mfrances17 mfrances17 force-pushed the textinputgroup-fix-basic-example-state branch from 396600d to 01f0df4 Compare September 25, 2023 20:40
@mfrances17 mfrances17 force-pushed the textinputgroup-fix-basic-example-state branch from 01f0df4 to 4d4c3f2 Compare September 25, 2023 21:03
@mfrances17
Copy link
Contributor Author

Removed yarn.lock from the commit.

@kmcfaul kmcfaul merged commit 8475a6d into patternfly:main Oct 9, 2023
10 checks passed
@mfrances17 mfrances17 deleted the textinputgroup-fix-basic-example-state branch October 24, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text input group - Basic example does not have state
5 participants