feat(Icons): Allow for more complex paths and svgs #11864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11864.surge.sh A11y report: https://patternfly-react-pr-11864-a11y.surge.sh |
rebeccaalpert
requested review from
thatblindgeye,
a team and
wise-king-sullyman
and removed request for
a team
rebeccaalpert
force-pushed
the
customicon
branch
from
83a5670 to
28436a5
Compare
thatblindgeye
requested changes
Jun 12, 2025
|
We talked to Michael Coker - going to drop hamburger icon since it's so specific that we lose path data unless it's in a button. We'll leave in improvements here to the other pieces so we can do this for more generic animated icons in the future. |
rebeccaalpert
force-pushed
the
customicon
branch
2 times, most recently
from
fd6b17d to
787f085
Compare
rebeccaalpert
force-pushed
the
customicon
branch
from
787f085 to
0b07e32
Compare
rebeccaalpert
changed the title
Allow for arrays of path data in addition to simple strings. Data can include classNames as well as multiple paths.
rebeccaalpert
force-pushed
the
customicon
branch
from
0b07e32 to
bc0e57e
Compare
|
Renamed! |
thatblindgeye
approved these changes
Jun 13, 2025
kmcfaul
approved these changes
Jun 13, 2025
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #11858
Also allow for arrays of path data in addition to simple strings. Add hamburger icon with array of path data.
When I add the path classes, the icon disappears, but looking at Eric and Michael's PRs, I get the feeling that they're necessary. It does look odd on the icons page though.
Additional issues: