feat(Nav): Added default nav item wrapper. Added support for nav item icons #10687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlabaj
requested review from
a team,
wise-king-sullyman,
kmcfaul,
mattnolting and
thatblindgeye
and removed request for
a team
This was
linked to
issues
Jul 1, 2024
|
Preview: https://patternfly-react-pr-10687.surge.sh A11y report: https://patternfly-react-pr-10687-a11y.surge.sh |
andrew-ronaldson
approved these changes
Jul 2, 2024
| @@ -193,8 +193,8 @@ export const NavItem: React.FunctionComponent<NavItemProps> = ({ | |||
| {...(hasFlyout && { ...ariaFlyoutProps })} | |||
| {...props} | |||
| > | |||
| {hasNavLinkWrapper ? <span className={css(`${styles.nav}__link-text`)}>{children}</span> : children} | |||
| {flyout && flyoutButton} | |||
| {icon && <span className={css(`${styles.nav}__link-icon`)}>{icon}</span>} | |||
There was a problem hiding this comment.
Suggested change
| {icon && <span className={css(`${styles.nav}__link-icon`)}>{icon}</span>} | |
| {icon && <span className={css(styles.navLinkIcon)}>{icon}</span>} |
thatblindgeye
requested changes
Jul 3, 2024
| @@ -193,8 +193,8 @@ export const NavItem: React.FunctionComponent<NavItemProps> = ({ | |||
| {...(hasFlyout && { ...ariaFlyoutProps })} | |||
| {...props} | |||
| > | |||
| {hasNavLinkWrapper ? <span className={css(`${styles.nav}__link-text`)}>{children}</span> : children} | |||
| {flyout && flyoutButton} | |||
There was a problem hiding this comment.
This will need to be added back in. Right now the Flyout example doesn't render the icon to indicate the item has any sort of interaction (item "Flyout link 3" in the following screenshot):
There was a problem hiding this comment.
oops that was a paste mistake! good catch!
thatblindgeye
approved these changes
Jul 3, 2024
nicolethoen
approved these changes
Jul 5, 2024
wise-king-sullyman
approved these changes
Jul 11, 2024
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9755 #10685
Additional issues: