Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PasswordStrength) remove popover in demo #10353

Merged

Conversation

Dominik-Petrik
Copy link
Contributor

What: Closes #10071

@patternfly-build
Copy link
Contributor

patternfly-build commented May 10, 2024

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR build doesn't reflect the changes properly, seems like this is an issue in other PRs as well. Pulling the branch locally and checking things look good

@tlabaj tlabaj requested a review from jessiehuff May 10, 2024 18:09
Copy link
Contributor

@jessiehuff jessiehuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good when I ran it locally 👍

@nicolethoen nicolethoen merged commit c626313 into patternfly:main May 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update popover in Password Strength demo
5 participants