Skip to content

Commit bc34872

Browse files
fix(LoginPage): updated markup for LoginMainHeader (#10880)
1 parent 5ae7154 commit bc34872

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

packages/react-core/src/components/LoginPage/LoginMainHeader.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export const LoginMainHeader: React.FunctionComponent<LoginMainHeaderProps> = ({
2424
headerUtilities = null,
2525
...props
2626
}: LoginMainHeaderProps) => (
27-
<header className={css(styles.loginMainHeader, className)} {...props}>
27+
<div className={css(styles.loginMainHeader, className)} {...props}>
2828
{title && (
2929
<Title headingLevel="h2" size={TitleSizes['3xl']}>
3030
{title}
@@ -33,6 +33,6 @@ export const LoginMainHeader: React.FunctionComponent<LoginMainHeaderProps> = ({
3333
{subtitle && <p className={css(styles.loginMainHeaderDesc)}>{subtitle}</p>}
3434
{headerUtilities && <div className={css(styles.loginMainHeaderUtilities)}>{headerUtilities}</div>}
3535
{children}
36-
</header>
36+
</div>
3737
);
3838
LoginMainHeader.displayName = 'LoginMainHeader';

packages/react-core/src/components/LoginPage/__tests__/__snapshots__/LoginMainHeader.test.tsx.snap

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,23 @@
22

33
exports[`LoginMainHeader className is added to the root element 1`] = `
44
<DocumentFragment>
5-
<header
5+
<div
66
class="pf-v6-c-login__main-header extra-class"
77
/>
88
</DocumentFragment>
99
`;
1010

1111
exports[`LoginMainHeader renders with PatternFly Core styles 1`] = `
1212
<DocumentFragment>
13-
<header
13+
<div
1414
class="pf-v6-c-login__main-header"
1515
/>
1616
</DocumentFragment>
1717
`;
1818

1919
exports[`LoginMainHeader title and subtitle are rendered correctly 1`] = `
2020
<DocumentFragment>
21-
<header
21+
<div
2222
class="pf-v6-c-login__main-header"
2323
>
2424
<h2
@@ -34,6 +34,6 @@ exports[`LoginMainHeader title and subtitle are rendered correctly 1`] = `
3434
>
3535
Use LDAP credentials
3636
</p>
37-
</header>
37+
</div>
3838
</DocumentFragment>
3939
`;

packages/react-core/src/components/LoginPage/__tests__/__snapshots__/LoginPage.test.tsx.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ exports[`check loginpage example against snapshot 1`] = `
2424
<main
2525
class="pf-v6-c-login__main"
2626
>
27-
<header
27+
<div
2828
class="pf-v6-c-login__main-header"
2929
>
3030
<h2
@@ -35,7 +35,7 @@ exports[`check loginpage example against snapshot 1`] = `
3535
>
3636
Log into your account
3737
</h2>
38-
</header>
38+
</div>
3939
<div
4040
class="pf-v6-c-login__main-body"
4141
/>

0 commit comments

Comments
 (0)