perf(angular): upgrade to Angular 1.7.7

[redallen]

Description

Closes #766 .

PR Checklist

• Unit tests are included
• Screenshots are attached (if there are visual changes in the UI)
• A Designer (@beanh66) is assigned as a reviewer (if there are visual changes in the UI)
• A CSS rep (@cshinn) is assigned as a reviewer (if there are visual changes in the UI)
• Fix pf-bootstrap-select directive unit tests
• Fix pfCanvas and pfCanvasEditor
• Fix example script urls (I trust <script src="http://localhost:8000/grunt-scripts/jquery.js"></script> will become <script src="https://www.patternfly.org/angular-patternfly/grunt-scripts/jquery.js"></script> somewhere in the deploy)

Additional notes

All urls in the app have changed to use #! instead of #. See the Angular 1.6 changelog. As a result, we need to upgrade to grunt-uidocs-generator.

[dtaylor113]

Why the change to directive? pfAggregateStatusCard does appear to be a component:

angular.module( 'patternfly.card' ).component('pfAggregateStatusCard', {

[redallen]

Needed for grunt-ui-docs to even show the component on the generated doc webpage.

[dgutride]

Yeah - something changed after angular 1.6 that requires the name match directive now (and components aren't natively supported by grunt-ui-docs or ngdocs)

[dtaylor113]

Ok, thought it was something along those lines

[dtaylor113]

Hi @redallen, great work!

I downloaded this branch and ran though most uidoc examples: charts, wizards, toolbar, table, nav, notification drawer, filter, etc... Everything ran as expected! Plus, all unit tests pass, so I think this is ready to go, nice work!

Couple of issues:

1. You have to squash and change the commit msg(s) to a single: "perf(angular): upgrade to Angular 1.7.7" (not the PR description). Assuming we are going with a Major change (due to # files changed, as opposed to 'breaking changes'.)

2. I think I have to manually merge this PR, looks like coveralls is failing, not sure why it would though?

Thanks,

• Dave

[redallen]

I just squashed the commit and force pushed. Coveralls was failing because test coverage went down 0.8% (not sure why...)

[dtaylor113]

Also, pls note that the 'npm publish' step will most likely fail after merge. I will have to create a PR to manually update the version number, similar to #770

[jeff-phillips-18]

Not sure we need to do a Major release only because of the number of files. If it's non-breaking, there shouldn't be a need to bump the major version.

[dtaylor113]

Not sure we need to do a Major release only because of the number of files. If it's non-breaking, there shouldn't be a need to bump the major version.

I 'somewhat' agree, but there are a lot of source code changes and dependency version updates. I'm for minimizing risk to existing projects who don't necessarily need angular 1.7.7. Even though all unit tests are passing, I'm concerned dependency version updates may affect existing customers in ways we aren't testing for.