simpleFilter dropdown button now works works angular-bootstrap #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change, the addition of the dropdown attribute to the encapsulating div and dropdown-toggle attribute on the dropdown button does not modify any original behavior, but does allow the button to work with the angular-bootstrap
|
LGTM |
| <div class="input-group-btn"> | ||
| <button type="button" class="btn btn-default dropdown-toggle filter-fields" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"> | ||
| <div dropdown class="input-group-btn"> | ||
| <button dropdown-toggle type="button" class="btn btn-default dropdown-toggle filter-fields" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"> |
There was a problem hiding this comment.
I agree with this change but we need to add angular-bootstrap as a devDependency I believe.
There was a problem hiding this comment.
LGTM
On Wed, Sep 9, 2015 at 2:48 PM, Eleni Rundle notifications@github.com
wrote:
In src/filters/simple-filter.html
#75 (comment)
:@@ -2,8 +2,8 @@
-- --I agree with this change but we need to add angular-bootstrap as a
devDependency I believe.—
Reply to this email directly or view it on GitHub
https://github.com/patternfly/angular-patternfly/pull/75/files#r39081107
.
Dave Taylor
Principle Software Engineer
(978) 392 - 1016
erundle
pushed a commit
that referenced
this pull request
Sep 9, 2015
simpleFilter dropdown button now works works angular-bootstrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change, the addition of the dropdown attribute to the encapsulating div and dropdown-toggle attribute on the dropdown button does not modify any original behavior, but does allow the button to work with the angular-bootstrap