fix pfTableView: border style not in line with PatternFly #664
Conversation
src/pagination/pagination.less
Outdated
| align-items: center; | ||
| .per-page-label { | ||
| padding-left: 10px; | ||
| } |
There was a problem hiding this comment.
Shouldn't this be in Patternfly styling? Not sure why the original was here. @dtaylor113 ?
There was a problem hiding this comment.
Without the less, I get:
I'd have to dive deeper into the css used in the a-pf pagination component. I'm fairly certain it is very close to the css used in pf core.
There was a problem hiding this comment.
Can this change be done in a separate PR so we can merge & close this one?
There was a problem hiding this comment.
Looks like the real issue here is that the pagination component should have the 'table-view-pf-pagination' selector as well as the 'content-view-pf-pagination'. If we add that for the pagination component when used for a table this change would not be necessary.
|
Commit message needs to be formatted for semantic release. See https://github.com/patternfly/angular-patternfly#git-commit-guidelines |
|
Formatted the commit message according to semantic releases |
There was a problem hiding this comment.
Hi, just verified all we need is 'table-view-pf-pagination' added to pagination.html, and the 'border-collapse' css attribute added to table.less.
Please see my commit to see the changes required.
|
Your requested changes have been done. |
|
@jeff-phillips-18, need your approval -thanks |
fix #663
Make the pfTableView borders thinner according to PatternFly's Table View.
@cshinn