Convert notification module #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaylor113
reviewed
Dec 22, 2016
| ctrl.updateShowClose(); | ||
| } | ||
| }); | ||
|
|
There was a problem hiding this comment.
Trying out Object.defineProperty? Couldn't this also be handled by $onChanges?
There was a problem hiding this comment.
We'd have to change showClose from @ to < to do that, I was trying to leave the interface the same so it can use {{ }}. I don't mind changing and documenting if you prefer @dtaylor113
There was a problem hiding this comment.
No, I think it preferable to keep the API the same. -thanks!
dtaylor113
approved these changes
Dec 22, 2016
| $scope.types = ['success','info','danger', 'warning']; | ||
| $scope.type = $scope.types[0]; | ||
| $scope.isPersistent = false; | ||
| $scope.notifications = $rootScope.notifications; |
There was a problem hiding this comment.
Is this still being used? I don't see where.
|
After making the notification persistent and then hitting the X to remove it, the demo becomes broken. |
…o component style
…ctionality change
dgutride
force-pushed
the
convert-notification-module
branch
from
78d098e to
d2aa17d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts notification directives to component style, also includes making sure test and lint works correctly.
Notification service also converted to not use $rootScope any longer.