Change sortId to currentField in sort directive #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In documentatin was type, where it said to use sortId to select element from which items should be filtered, however currentField is the option which shuld be used. No changes in code, just in usage documentation
|
I am not sure whether dist folder should be pushed as well, but since its using bower I assume it's nice to keep changes in dist for upstream, right? |
| chart = c3.generate(chartData); | ||
| if (scope.getChartCallback) { | ||
| scope.getChartCallback(chart); | ||
| } | ||
| } |
There was a problem hiding this comment.
Yeah, I figured that #226 did not included dist folder. I'll keep it in.
|
Yes, these dist files do need to be included. |
|
LGTM 👍 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In documentatin was type, where it said to use sortId to select element from which items should be filtered, however currentField is the option which shuld be used.
No changes in code, just in usage documentation.