Changes from code review. . .

Author: dgutride

src/charts/topology/examples/topology-view.js

@@ -4,7 +4,7 @@
  * @restrict E
  *
  * @description
- *   Component for rendering a topology chart.  Individual nodes and relationships can be represented with this view.  CSS is especially important for rendering the noes and lines.  The example inline contains specific examples that can be used to change the icon size and the line type of the relationships.
+ *   Component for rendering a topology chart.  Individual nodes and relationships can be represented with this view.  CSS is especially important for rendering the nodes and lines.  The example inline contains specific examples that can be used to change the icon size and the line type of the relationships.
  *
  *   In addition; searching, filtering and label visibility is also supported.<br/>
  *
@@ -172,11 +172,11 @@
           "fontfamily": "FontAwesome"
         },
         "Host": {
-  				"type": "glyph",
-	  			"icon": "",
-			  	"fontfamily": "PatternFlyIcons-webfont"
-		  	},
-		  	"Vm": {
+          "type": "glyph",
+          "icon": "",
+          "fontfamily": "PatternFlyIcons-webfont"
+        },
+        "Vm": {
           "type": "glyph",
           "icon": "",
           "fontfamily": "PatternFlyIcons-webfont"
@@ -186,41 +186,41 @@
           "icon": "",
           "fontfamily": "PatternFlyIcons-webfont"
         }
-			},
+      },
     });
 
     $rootScope.data = datasets[index];
 
     var nodeKinds = {
-			"ContainerReplicator": true,
-			"ContainerGroup": true,
-			"Container": true,
-			"ContainerNode": true,
-			"ContainerService": true,
-			"Host": true,
-			"Vm": true,
-			"ContainerRoute": true,
-			"ContainerManager": true
-		};
+      "ContainerReplicator": true,
+      "ContainerGroup": true,
+      "Container": true,
+      "ContainerNode": true,
+      "ContainerService": true,
+      "Host": true,
+      "Vm": true,
+      "ContainerRoute": true,
+      "ContainerManager": true
+    };
 
-		$rootScope.kinds = nodeKinds;
+    $rootScope.kinds = nodeKinds;
 
-		var icons = $rootScope.data.icons;
+    var icons = $rootScope.data.icons;
     $scope.nodes = {};
-		for(var kind in nodeKinds) {
-		  var icon = icons[kind];
-		  $scope.nodes[kind] = {
-		    "name": kind,
-		    "enabled": nodeKinds[kind],
-		    "radius": 16,
-		    "textX": 0,
-		    "textY": 5,
-		    "height": 18,
-		    "width": 18,
-		    "icon": icon.icon,
-		    "fontFamily": icon.fontfamily
-		  };
-		}
+    for(var kind in nodeKinds) {
+      var icon = icons[kind];
+      $scope.nodes[kind] = {
+        "name": kind,
+        "enabled": nodeKinds[kind],
+        "radius": 16,
+        "textX": 0,
+        "textY": 5,
+        "height": 18,
+        "width": 18,
+        "icon": icon.icon,
+        "fontFamily": icon.fontfamily
+      };
+    }
 
     // Individual values can also be set for specific icons
     $scope.nodes.ContainerService.textY = 9;

src/charts/topology/topology.component.js

@@ -28,7 +28,6 @@ angular.module('patternfly.charts').component('pfTopology', {
     ctrl.$onInit = function () {
       $element.css("display", "block");
       options = {"force": ctrl.force, "radius": ctrl.radius};
-      //graph = topologyGraph($element[0], notify, options);
       ctrl.showLabels = false;
 
       $element.on("$destroy", function () {
@@ -598,27 +597,27 @@ angular.module('patternfly.charts').component('pfTopology', {
     }
 
     function getItemStatusClass (d) {
-      switch (d.item.status) {
-      case "OK":
-      case "Active":
-      case "Available":
-      case "On":
-      case "Ready":
-      case "Running":
-      case "Succeeded":
-      case "Valid":
+      switch (d.item.status.toLowerCase()) {
+      case "ok":
+      case "active":
+      case "available":
+      case "on":
+      case "ready":
+      case "running":
+      case "succeeded":
+      case "valid":
         return "success";
-      case "NotReady":
-      case "Failed":
-      case "Error":
-      case "Unreachable":
+      case "notready":
+      case "failed":
+      case "error":
+      case "unreachable":
         return "error";
-      case 'Warning':
-      case 'Waiting':
-      case 'Pending':
+      case 'warning':
+      case 'waiting':
+      case 'pending':
         return "warning";
-      case 'Unknown':
-      case 'Terminated':
+      case 'unknown':
+      case 'terminated':
         return "unknown";
       }
     }