fix(pfFilter): do not allow empty filters

dtaylor113 · dtaylor113 · commit 974b57f7091a · 2017-08-23T14:13:18.000-04:00
diff --git a/src/filters/simple-filter/filter-fields-component.js b/src/filters/simple-filter/filter-fields-component.js
@@ -89,7 +89,7 @@ angular.module('patternfly.filters').component('pfFilterFields', {
     }
 
     function onValueKeyPress (keyEvent) {
-      if (keyEvent.which === 13) {
+      if (keyEvent.which === 13 && ctrl.currentValue && ctrl.currentValue.length > 0) {
         ctrl.addFilterFn(ctrl.currentField, ctrl.currentValue);
         ctrl.currentValue = undefined;
         keyEvent.stopPropagation();

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ angular.module('patternfly.filters').component('pfFilterFields', {`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`function onValueKeyPress (keyEvent) {`
`92`		`- if (keyEvent.which === 13) {`
	`92`	`+ if (keyEvent.which === 13 && ctrl.currentValue && ctrl.currentValue.length > 0) {`
`93`	`93`	`ctrl.addFilterFn(ctrl.currentField, ctrl.currentValue);`
`94`	`94`	`ctrl.currentValue = undefined;`
`95`	`95`	`keyEvent.stopPropagation();`