DPL: Working Fix For Pattern Lab Lineages When Using Custom Twig Namespaces #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extra character from InstallerUtil so dev branch works
… comments to explain my PHP chicken scratch. Addresses existing open issue #3 and corresponds with the 2nd half of work mentioned in drupal-pattern-lab/patternengine-php-twig#1
Updating global data to use `yml` or `yaml`
v2.8.0 RC - Merging Latest on Dev into Master
This reverts commit 8a51a73.
This reverts commit 505f32c.
Replace possible dots in pattern names with dashes
…-lineages Fix for Broken Lineage Functionality in PL When Using Twig templates w/ Path Namespaces (ie. Drupal 8-friendly Paths)
Don't overwrite nameClean if it has already been set
…exist when scanning the pattern source directory for patterns; adds the RecursiveIteratorIterator flag to follow symbolic links while still continuing to skip dots (. and ..). This opens the door for some creative workarounds to the rigid way Pattern Lab expects pattern templates to be organized at the file system level + how the physical path to a pattern determines how it's organized in Pattern Lab... pattern-lab#28
Allow Pattern Lab to follow pattern symlinks when registering patterns
… Default files in the public dir if entire directory gets wiped. Solves #14
…ic-dir Working solution to regenerate missing styleguideKit index.html in the public directory
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original pull request from the Drupal Pattern Lab Fork which already merged in these 9 previous PRs.
Addresses original issue opened here: EvanLovely/plugin-twig-namespaces#4
Without this workaround when using the Pattern Lab Twig Namespaces plugin using a path / directory other than the one PL would normally assign (ex. one single
@mylibraryalias for any pattern to be included by) the original Lineage fix stops working entirely and you get dozens and dozens and dozens of warnings saying you're PL includes / embeds / extends aren't referencing arealpattern.CC @evanmwillhite @jesconstantine @bradfrost