Skip to content

fix(loadPattern): Check proper data file paths for modification #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2018
Merged

fix(loadPattern): Check proper data file paths for modification #791

merged 1 commit into from
Jan 31, 2018

Conversation

bmuenzenmeyer
Copy link
Member

Closes #790

Summary of changes:

Explicitly append the known data filenames when searching for changes.

I think this was introduced in #634 when the extension was no longer used with data_loader (😎) but removed it from the caller (:bug:)

@coveralls
Copy link

coveralls commented Jan 31, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 72.062% when pulling b7ba5b0 on fix-watch-pattern-data-file into 0fc9bd7 on dev.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 72.062% when pulling b7ba5b0 on fix-watch-pattern-data-file into 0fc9bd7 on dev.

@bmuenzenmeyer bmuenzenmeyer merged commit cd395c8 into dev Jan 31, 2018
@bmuenzenmeyer bmuenzenmeyer deleted the fix-watch-pattern-data-file branch January 31, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmuenzenmeyer @coveralls