refactor: corrected some aspects out of eslint feedback #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-unused-vars' its usage has been removed with pattern-lab@70fe9b6#diff-75bedd8b06cebb50236c7c659b539b0fa984746f8abb3d7a5dc6a92b3763fcc0
…ed-vars" This isn't in use anymore since commit pattern-lab@2ff8e1c#diff-b26f09ed0fc0febb6d869ff60e410d9d8efd300b4b6c2facbf668cd4555e27a2L39
…er used no-unused-vars" as its usage hasn't been in use since commit pattern-lab@2ff8e1c#diff-b26f09ed0fc0febb6d869ff60e410d9d8efd300b4b6c2facbf668cd4555e27a2R45
…sed-vars" and css and svg as well
…vars" and filePath as well
…nused-vars" as its usage has been removed with commit pattern-lab@deb4783#diff-25426a917b53575c0f0efc5674ee70c4d2c8671f9ade4f9d994db43c9552302bL217
|
Do we need the commented-out code, or can we remove it entirely? |
@JosefBredereck I was struggling with this question as well. I decided to leave it in as we don't need it at the moment, but as soon as someone might need e.g. the |
I've just decided to remove them. So we should be good to go now. |
JosefBredereck
approved these changes
Jan 1, 2022
mfranzke
deleted the
refactor/corrected-some-aspects-out-of-eslint-feedback
branch
|
PR was released with v5.16.0 |
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
…1399) * refactor: fixed 'warning 'data' is assigned a value but never used no-unused-vars' its usage has been removed with pattern-lab@70fe9b6#diff-75bedd8b06cebb50236c7c659b539b0fa984746f8abb3d7a5dc6a92b3763fcc0 * refactor: fixed "warning 'event' is defined but never used no-unused-vars" * refactor: fixed "warning 'NodePart' is defined but never used no-unused-vars" This isn't in use anymore since commit pattern-lab@2ff8e1c#diff-b26f09ed0fc0febb6d869ff60e410d9d8efd300b4b6c2facbf668cd4555e27a2L39 * refactor: fixed "warning 'customElement' is defined but never used no-unused-vars" * refactor: fixed "warning 'previousValues' is assigned a value but never used no-unused-vars" as its usage hasn't been in use since commit pattern-lab@2ff8e1c#diff-b26f09ed0fc0febb6d869ff60e410d9d8efd300b4b6c2facbf668cd4555e27a2R45 * refactor: fixed "error Method 'slotify' expected a return value consistent-return" * refactor: fixed "warning 'unsafeCSS' is defined but never used no-unused-vars" and css and svg as well * refactor: fixed "warning 'event' is defined but never used no-unused-vars" * refactor: fixed "warning 'event' is defined but never used no-unused-vars" and filePath as well * refactor: fixed "warning 'pm' is assigned a value but never used no-unused-vars" as its usage has been removed with commit pattern-lab@deb4783#diff-25426a917b53575c0f0efc5674ee70c4d2c8671f9ade4f9d994db43c9552302bL217 * refactor: fixed "warning 'options' is defined but never used no-unused-vars" * chore: removing the previously out-commented parts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Fixed some of the aspects that comes out of eslint feedback (via
yarn lint).