Skip to content

chore: update @basalt/twig-renderer to version 2 #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patrickcate
Copy link
Contributor

Closes #1259

updates @basalt/twig-renderer to version 2

@JosefBredereck
Copy link
Contributor

It is that simple? 😨
That would be awesome.

@JosefBredereck JosefBredereck self-requested a review January 12, 2021 07:19
@JosefBredereck
Copy link
Contributor

Is that update downward compatible?

@patrickcate
Copy link
Contributor Author

Is that update downward compatible?

It technically represents a break change.

How are breaking changes in a single package handled in a monorepo?

@JosefBredereck
Copy link
Contributor

JosefBredereck commented Feb 3, 2021

How are breaking changes in a single package handled in a monorepo?

I'm not sure how this would be handled.

I only needed this information for future releases to inform all users via a release note.

@JosefBredereck JosefBredereck merged commit 63b366e into pattern-lab:dev Feb 3, 2021
@JosefBredereck JosefBredereck added released 🚀 breaking ❗ Use this labe if the change will break the current pattern lab behavior and removed ready for release 🆗 labels Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking ❗ Use this labe if the change will break the current pattern lab behavior released 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update engine-twig-php to latest @basalt/twig-renderer
2 participants