Fix IE11 error - SCRIPT438: Object doesn't support property or method 'forEach' #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringods
suggested changes
Sep 2, 2020
packages/uikit-workshop/src/scripts/components/modal-styleguide.js
Outdated
Show resolved
Hide resolved
|
I would love to see pattern lab running in IE11. I had some issues with that for a customer. |
|
FWIW, the overhauled Pattern Lab UI previously was working ok (albeit a
little sluggish at times + with no CSS custom vars support) in IE 11...
Looks like the main UI is rendering (doing a super quick spot check) so
hopefully there's just a few bugs to smooth over:
https://www.webpagetest.org/result/200902_M8_2e9cad478c95bbfc70057edddc4a674f/1/screen_shot/#step_1
…On Wed, Sep 2, 2020 at 1:04 PM Josef Bredreck ***@***.***> wrote:
I would love to see pattern lab running in IE11. I had some issues with
that for a customer.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1255 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMK2OOKPUMGHSSMOOIUWQ3SDZ3LVANCNFSM4QRH23DA>
.
|
|
Sorry that I highjacked this PR but there was much more to do then just adding an if. |
ringods
suggested changes
Sep 3, 2020
packages/uikit-workshop/src/scripts/components/modal-styleguide.js
Outdated
Show resolved
Hide resolved
ringods
approved these changes
Sep 4, 2020
|
@JosefBredereck @ringods with the new syntax of the |
shaal
commented
Sep 4, 2020
packages/uikit-workshop/src/scripts/components/modal-styleguide.js
Outdated
Show resolved
Hide resolved
packages/uikit-workshop/src/scripts/components/modal-styleguide.js
Outdated
Show resolved
Hide resolved
JosefBredereck
approved these changes
Sep 4, 2020
JosefBredereck
requested review from
sghoweri
and removed request for
sghoweri
|
I just tested all changes; with the production source, we had so many problems in the past. Everything works fine in IE11 now. I will merge now. |
|
Released with v5.13.1 |
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
* Fix IE11 error - SCRIPT438: Object doesn't support property or method 'forEach' * Update uikit polyfills to run pl in ie11 * Update packages/uikit-workshop/src/scripts/components/modal-styleguide.js * Update modal-styleguide.js Co-authored-by: Ofer Shaal <ofer@3paces.com> Josef Bredreck <slime.games@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running PL 5.13.0 on Internet Explorer 11, and I am getting this error.
SCRIPT438: Object doesn't support property or method 'forEach'Summary of changes:
When this class is not in a page
'.pl-js-pattern-extra-toggle', the array is empty, andforEachthrow an error.Checking that the array is not empty before running forEach function.