Fix broken "open in new tab" link in UIKit #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng Redux update when the URL changes
|
@bmuenzenmeyer or @JosefBredereck any chance one of you guys could do a super quick review of this UIKit hotfix? |
JosefBredereck
approved these changes
May 9, 2020
Ah, I totally missed that this fix was already in #1143 (good catch!). Thanks @JosefBredereck! |
|
Released in v5.10.1 |
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
…-open-in-new-tab Fix broken "open in new tab" link in UIKit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed this was broken while reviewing a separate PR... this PR should fix the "Open In New Tab" link in Pattern Lab's context menu so it now opens the correct HTML file vs a broken "undefined" page.
Before (Broken)
After (Working)
