Skip to content

Update pattern discovery and fix "view all" issues #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Aug 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
2237301
Update object_factory and view all page behavior
JosefBredereck Apr 12, 2020
edc4b0c
Various changes to file and pattern creation
JosefBredereck Apr 12, 2020
f9ca91e
Merge branch 'dev' of https://github.com/JosefBredereck/patternlab-no…
JosefBredereck Apr 12, 2020
c94531b
Ability for viewall page links and updated test to realworld
JosefBredereck Apr 13, 2020
e39a881
Fix "Open In New Tab" incorrect link
JosefBredereck Apr 13, 2020
e72b8b4
#1143: Add func. to specify if pattern has own dir
JosefBredereck Apr 17, 2020
5003a6a
#1143: Add test and fix remaining errors
JosefBredereck Apr 17, 2020
03d9287
Merge branch 'dev' into dev
sghoweri Apr 25, 2020
ffcd615
#1143: Fix translations causing nav bug
JosefBredereck Apr 25, 2020
2475cac
#1143: Change property to proper name
JosefBredereck Apr 25, 2020
1e7ed0d
Merge remote-tracking branch 'upstream/dev' into dev
JosefBredereck Apr 26, 2020
fec2492
#1143: Revert translation attempt
JosefBredereck Apr 26, 2020
7dd18f9
#1143: Fix naming of view-all links
JosefBredereck Apr 26, 2020
cf96cb0
Merge remote-tracking branch 'upstream/dev' into dev
JosefBredereck Apr 27, 2020
cf4f092
#1143 don't show all page if noViewall is active
JosefBredereck Apr 27, 2020
2212d7f
Merge branch 'dev' into dev
JosefBredereck May 2, 2020
0bc5802
Merge branch 'dev' into dev
bmuenzenmeyer May 5, 2020
4a6ca26
Merge branch 'dev' into dev
bmuenzenmeyer May 6, 2020
c27907f
#1143: Fix some spell-check errors
JosefBredereck May 6, 2020
49c098c
#1143: Remove set current url as it gets fixed in #1202
JosefBredereck May 9, 2020
d5e1c0d
Merge remote-tracking branch 'upstream/dev' into dev
JosefBredereck May 9, 2020
c6d46a4
Merge remote-tracking branch 'upstream/dev' into dev
JosefBredereck Jul 1, 2020
2022f64
#1143: Make flat patterns on view all pages optional
JosefBredereck Jul 1, 2020
dff1000
#1143 update deeper nesting
JosefBredereck Jul 1, 2020
243eef0
#1143 Fix test
JosefBredereck Jul 1, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .prettierrc
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"singleQuote": true,
"trailingComma": "es5"
"trailingComma": "es5",
"endOfLine": "auto"
}
1 change: 1 addition & 0 deletions packages/cli/test/fixtures/patternlab-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
"patternExportDirectory": "./pattern_exports/",
"patternExportPatternPartials": [],
"patternMergeVariantArrays": true,
"renderFlatPatternsOnViewAllPages": false,
"serverOptions": {
"wait": 1000
},
Expand Down
1 change: 1 addition & 0 deletions packages/core/patternlab-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"patternExportPreserveDirectoryStructure": true,
"patternExportRaw": false,
"patternMergeVariantArrays": true,
"renderFlatPatternsOnViewAllPages": false,
"serverOptions": {
"wait": 1000
},
Expand Down
5 changes: 3 additions & 2 deletions packages/core/src/lib/markdown_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ const markdown_parser = function() {
let returnObject = {};

try {
//for each block process the yaml frontmatter and markdown
const frontmatterRE = /---\r?\n{1}([\s\S]*)---\r?\n{1}([\s\S]*)+/gm;
// for each block process the yaml frontmatter and markdown
// even if the pattern only has pattern data without further documentation
const frontmatterRE = /---\r?\n{1}([\s\S]*)---([\s\S]*)+/gm;
const chunks = frontmatterRE.exec(block);

if (chunks) {
Expand Down
Loading