Skip to content

fix: publish auto-generated “dist” folder when publishing to NPM #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

sghoweri
Copy link
Contributor

Updates the UIKit package.json to tell NPM to publish the auto-generated dist folder when publishing. Fixes the missing “dist” folder on NPM reported by @thethomic!

@sghoweri sghoweri added this to the v5.0.1 milestone Oct 28, 2019
@sghoweri
Copy link
Contributor Author

^ probably wouldn’t hurt to publish a canary release to double-check this is working as expected before we cut our next release. 🙂

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.373% when pulling 8829429 on hotfix/missing-uikit-dist into e92bac8 on dev.

@bmuenzenmeyer bmuenzenmeyer merged commit dfd3e57 into dev Oct 28, 2019
@bmuenzenmeyer bmuenzenmeyer deleted the hotfix/missing-uikit-dist branch October 28, 2019 11:55
@bmuenzenmeyer
Copy link
Member

^ probably wouldn’t hurt to publish a canary release to double-check this is working as expected before we cut our next release. 🙂

yeah - anytime you automate deployment you now gotta test that right 👍

@bmuenzenmeyer
Copy link
Member

dont think the fixed versioning works with our current publish script - it only did the conventional-commit changes

Successfully published:

  • @pattern-lab/edition-node-gulp@5.0.1
  • @pattern-lab/edition-node@5.0.1
  • @pattern-lab/edition-twig@5.0.1
  • @pattern-lab/uikit-workshop@5.0.1
    lerna success published 4 packages

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
…ikit-dist

fix: publish auto-generated “dist” folder when publishing to NPM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants