Skip to content

Add starterkit-handlebars-vanilla to CLI #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2019
Merged

Conversation

bradfrost
Copy link
Member

Added starterkit-handlebars-vanilla to the list of available starterkits; updated some formatting

Also change some formatting and add a little more context
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.095% when pulling 36317a9 on add-handlebars-vanilla into cc0d797 on dev.

Copy link
Member

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this Brad! I like the consistency with the Edition inquiries by changing this

@bmuenzenmeyer bmuenzenmeyer merged commit 91b3650 into dev Oct 12, 2019
@bmuenzenmeyer bmuenzenmeyer deleted the add-handlebars-vanilla branch October 12, 2019 20:21
@ringods
Copy link
Contributor

ringods commented Oct 14, 2019

@bradfrost @bmuenzenmeyer I still have to publish my starterkits on npmjs.com, but once there, can I submit a PR to promote them via the CLI too?

https://gitlab.com/ringods/starterkit-building-blocks
https://gitlab.com/ringods/starterkit-zoho-sites

@bmuenzenmeyer
Copy link
Member

@ringods I am not sure how best to handle that - as inevitably a list containing too many choices would be daunting for a user to choose from.

I understand being able to promote community starterkits, plugins, etc would be a big win, however. Right now the docs site links to this page which could certainly be improved too.

do you have thoughts @bradfrost? this is a "product vision" sorta question

@ringods
Copy link
Contributor

ringods commented Oct 14, 2019

@bmuenzenmeyer there are only wiki pages for plugins and patternengines, not for starterkits. A new page should be added then where starterkits could be listed then.

Personally, I dislike the use of Github wiki pages because I can't send a PR to contribute content there. hint 😉

If you don't mind writing Asciidoc rather than Markdown, have a look at Antora to create a single site to document multiple versions of multiple components coming from one or more repositories. Nice example: https://docs.couchbase.com/home/index.html

@bmuenzenmeyer
Copy link
Member

@bmuenzenmeyer there are only wiki pages for plugins and patternengines, not for starterkits. A new page should be added then where starterkits could be listed then.

Personally, I dislike the use of Github wiki pages because I can't send a PR to contribute content there. hint 😉

You are right the wiki is not a perfect solution, nor the best UX. most of the content there was borne out of a need for speed and I have been concertedly trying to move content into patternlab.io over time.

@bradfrost is working on some bigger changes to the site - which I hope will better incorporate community

that being said, I created https://github.com/pattern-lab/patternlab-node/wiki/Official-and-Community-Starterkits with your contributions, they look great!

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
…anilla

Add starterkit-handlebars-vanilla to CLI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants