Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need recursive partial inclusion #156

Closed
e2tha-e opened this issue Oct 2, 2015 · 1 comment
Closed

Need recursive partial inclusion #156

e2tha-e opened this issue Oct 2, 2015 · 1 comment

Comments

@e2tha-e
Copy link
Contributor

e2tha-e commented Oct 2, 2015

Bug: Since partial inclusion is currently iterative, if a Mustache file includes a partial that diveSync will iterate on later because it is sorted higher alphanumerically, Pattern Lab will fail.

To replicate:

  • Create source/_patterns/02-organisms/00-global/02-test.mustache
  • Enter some dummy content: <h1>Foo</h1>
  • Include that partial anywhere in source/_patterns/02-organisms/00-global/00-header.mustache
  • {{> organisms-test }}
  • View the Pattern Lab in a browser - completely broken

Fix: need recursive inclusion of partials

@bmuenzenmeyer
Copy link
Member

This will auto-close when it reaches master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants