Skip to content

Commit

Permalink
Fix 467
Browse files Browse the repository at this point in the history
  • Loading branch information
XmiliaH committed Aug 28, 2022
1 parent 6fcb707 commit d9a7f3c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/setup-sandbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ Object.defineProperties(global, {
global: {value: global, writable: true, configurable: true, enumerable: true},
globalThis: {value: global, writable: true, configurable: true},
GLOBAL: {value: global, writable: true, configurable: true},
root: {value: global, writable: true, configurable: true}
root: {value: global, writable: true, configurable: true},
Error: {value: LocalError}
});

if (!localReflectDefineProperty(global, 'VMError', {
Expand Down
7 changes: 7 additions & 0 deletions test/vm.js
Original file line number Diff line number Diff line change
Expand Up @@ -1070,6 +1070,13 @@ describe('VM', () => {
Error.prepareStackTrace = undefined;
stack.process
`));
assert.throws(()=>vm2.run(`(()=>{
const OldError = Error;
global.Error = {prepareStackTrace: (_, c) => c.map(c => c.getThis()).find(a => a && a.process)};
const { stack } = new OldError();
global.Error = OldError;
return stack.process.mainModule;
})()`));
});

it('Node internal prepareStackTrace attack', () => {
Expand Down

0 comments on commit d9a7f3c

Please sign in to comment.