Omnibus cleanup from o1-mini's syntactic code review (microsoft#341)

RyanCavanaugh · jakebailey · web-flow · commit ef81146e2b6f · 2025-02-13T10:02:01.000-08:00
Co-authored-by: Jake Bailey &lt;5341706+jakebailey@users.noreply.github.com&gt;
diff --git a/internal/ast/ast.go b/internal/ast/ast.go
@@ -356,7 +356,7 @@ func (n *Node) TypeParameterList() *NodeList {
 			return funcLike.TypeParameters
 		}
 	}
-	panic("Unhandled case in Node.TypeParameters")
+	panic("Unhandled case in Node.TypeParameterList")
 }
 
 func (n *Node) TypeParameters() []*Node {
@@ -382,7 +382,7 @@ func (n *Node) MemberList() *NodeList {
 	case KindMappedType:
 		return n.AsMappedTypeNode().Members
 	}
-	panic("Unhandled case in Node.Members")
+	panic("Unhandled case in Node.MemberList")
 }
 
 func (n *Node) Members() []*Node {
@@ -7596,12 +7596,12 @@ type Pragma struct {
 type PragmaKindFlags = uint8
 
 const (
-	PragmaKindFlagsNone PragmaKindFlags = iota
-	PragmaKindTripleSlashXML
+	PragmaKindTripleSlashXML PragmaKindFlags = 1 << iota
 	PragmaKindSingleLine
 	PragmaKindMultiLine
-	PragmaKindAll     = PragmaKindTripleSlashXML | PragmaKindSingleLine | PragmaKindMultiLine
-	PragmaKindDefault = PragmaKindAll
+	PragmaKindFlagsNone PragmaKindFlags = 0
+	PragmaKindAll                       = PragmaKindTripleSlashXML | PragmaKindSingleLine | PragmaKindMultiLine
+	PragmaKindDefault                   = PragmaKindAll
 )
 
 type PragmaArgumentSpecification struct {
diff --git a/internal/checker/checker.go b/internal/checker/checker.go
@@ -2444,15 +2444,15 @@ func (c *Checker) checkObjectTypeForDuplicateDeclarations(node *ast.Node, checkP
 		if len(symbol.Declarations) > 1 {
 			var names map[string]int
 			if isStatic {
-				if instanceNames == nil {
-					instanceNames = make(map[string]int)
-				}
-				names = instanceNames
-			} else {
 				if staticNames == nil {
 					staticNames = make(map[string]int)
 				}
 				names = staticNames
+			} else {
+				if instanceNames == nil {
+					instanceNames = make(map[string]int)
+				}
+				names = instanceNames
 			}
 			if state := names[symbol.Name]; state != 2 {
 				if state == 1 {
@@ -4953,7 +4953,7 @@ func (iterationTypes *IterationTypes) getType(typeKind IterationTypeKind) *Type
 	case IterationTypeKindNext:
 		return iterationTypes.nextType
 	}
-	panic("Unhandled case in getIterationTypeOfIterable")
+	panic("Unhandled case in getType(IterationTypeKind)")
 }
 
 func (c *Checker) combineIterationTypes(iterationTypes []IterationTypes) IterationTypes {
@@ -7834,7 +7834,7 @@ func (c *Checker) isPromiseResolveArityError(node *ast.Node) bool {
 
 func getErrorNodeForCallNode(node *ast.Node) *ast.Node {
 	if ast.IsCallExpression(node) {
-		node := node.Expression()
+		node = node.Expression()
 		if ast.IsPropertyAccessExpression(node) {
 			node = node.Name()
 		}
@@ -12429,6 +12429,7 @@ func (c *Checker) markSymbolOfAliasDeclarationIfTypeOnly(aliasDeclaration *ast.N
 }
 
 func (c *Checker) markSymbolOfAliasDeclarationIfTypeOnlyWorker(aliasDeclarationLinks *AliasSymbolLinks, target *ast.Symbol, overwriteEmpty bool) bool {
+	// !!! following line checks aliasDeclarationLinks.typeOnlyDeclaration == nil twice; figure out what this was supposed to be
 	if target != nil && (aliasDeclarationLinks.typeOnlyDeclaration == nil || overwriteEmpty && aliasDeclarationLinks.typeOnlyDeclarationResolved && aliasDeclarationLinks.typeOnlyDeclaration == nil) {
 		exportSymbol := target.Exports[ast.InternalSymbolNameExportEquals]
 		if exportSymbol == nil {
@@ -12994,7 +12995,7 @@ func (c *Checker) addDeclarationToLateBoundSymbol(symbol *ast.Symbol, member *as
  */
 func (c *Checker) getMembersOfSymbol(symbol *ast.Symbol) ast.SymbolTable {
 	if symbol.Flags&ast.SymbolFlagsLateBindingContainer != 0 {
-		return c.getResolvedMembersOrExportsOfSymbol(symbol, MembersOrExportsResolutionKindresolvedMembers)
+		return c.getResolvedMembersOrExportsOfSymbol(symbol, MembersOrExportsResolutionKindResolvedMembers)
 	}
 	return symbol.Members
 }
@@ -14315,7 +14316,7 @@ func getUnionKey(types []*Type, origin *Type, alias *TypeAlias) string {
 		b.WriteByte('|')
 		b.WriteTypes(types)
 	default:
-		panic("Unhandled case in getUnionId")
+		panic("Unhandled case in getUnionKey")
 	}
 	b.WriteAlias(alias)
 	return b.String()
@@ -17869,7 +17870,7 @@ func (c *Checker) resolveIntersectionTypeMembers(t *Type) {
 func (c *Checker) appendSignatures(signatures []*Signature, newSignatures []*Signature) []*Signature {
 	for _, sig := range newSignatures {
 		if len(signatures) == 0 || core.Every(signatures, func(s *Signature) bool {
-			return c.compareSignaturesIdentical(s, sig, false /*partialMatch*/, false /*ignoreThisTypes*/, false /*ignoreReturnTypes*/, c.compareTypesIdentical) == 0
+			return c.compareSignaturesIdentical(s, sig, false /*partialMatch*/, false /*ignoreThisTypes*/, false /*ignoreReturnTypes*/, c.compareTypesIdentical) == TernaryFalse
 		}) {
 			signatures = append(signatures, sig)
 		}
diff --git a/internal/checker/relater.go b/internal/checker/relater.go
@@ -402,7 +402,7 @@ func (c *Checker) checkTypeRelatedToEx(
 }
 
 func createDiagnosticChainFromErrorChain(chain *ErrorChain, errorNode *ast.Node, relatedInfo []*ast.Diagnostic) *ast.Diagnostic {
-	for chain != nil && chain.message.ElidedInCompatabilityPyramid() {
+	for chain != nil && chain.message.ElidedInCompatibilityPyramid() {
 		chain = chain.next
 	}
 	if chain == nil {
diff --git a/internal/checker/types.go b/internal/checker/types.go
@@ -193,12 +193,12 @@ type MembersOrExportsResolutionKind int
 
 const (
 	MembersOrExportsResolutionKindResolvedExports MembersOrExportsResolutionKind = 0
-	MembersOrExportsResolutionKindresolvedMembers MembersOrExportsResolutionKind = 1
+	MembersOrExportsResolutionKindResolvedMembers MembersOrExportsResolutionKind = 1
 )
 
 type MembersAndExportsLinks [2]ast.SymbolTable // Indexed by MembersOrExportsResolutionKind
 
-// Links for syntheric spread properties
+// Links for synthetic spread properties
 
 type SpreadLinks struct {
 	leftSpread  *ast.Symbol // Left source for synthetic spread property
diff --git a/internal/compiler/diagnostics/diagnostics.go b/internal/compiler/diagnostics/diagnostics.go
@@ -35,7 +35,7 @@ type Message struct {
 	key                          string
 	text                         string
 	reportsUnnecessary           bool
-	elidedInCompatabilityPyramid bool
+	elidedInCompatibilityPyramid bool
 	reportsDeprecated            bool
 }
 
@@ -44,7 +44,7 @@ func (m *Message) Category() Category                 { return m.category }
 func (m *Message) Key() string                        { return m.key }
 func (m *Message) Message() string                    { return m.text }
 func (m *Message) ReportsUnnecessary() bool           { return m.reportsUnnecessary }
-func (m *Message) ElidedInCompatabilityPyramid() bool { return m.elidedInCompatabilityPyramid }
+func (m *Message) ElidedInCompatibilityPyramid() bool { return m.elidedInCompatibilityPyramid }
 func (m *Message) ReportsDeprecated() bool            { return m.reportsDeprecated }
 
 func (m *Message) Format(args ...any) string {
diff --git a/internal/compiler/diagnostics/diagnostics_generated.go b/internal/compiler/diagnostics/diagnostics_generated.go
diff --git a/internal/compiler/diagnostics/generate.go b/internal/compiler/diagnostics/generate.go
@@ -23,11 +23,12 @@ import (
 )
 
 type diagnosticMessage struct {
-	Category                     string `json:"category"`
-	Code                         int    `json:"code"`
-	ReportsUnnecessary           bool   `json:"reportsUnnecessary"`
-	ReportsDeprecated            bool   `json:"reportsDeprecated"`
-	ElidedInCompatabilityPyramid bool   `json:"elidedInCompatabilityPyramid"`
+	Category           string `json:"category"`
+	Code               int    `json:"code"`
+	ReportsUnnecessary bool   `json:"reportsUnnecessary"`
+	ReportsDeprecated  bool   `json:"reportsDeprecated"`
+	// spelling error here is [sic] in Strada
+	ElidedInCompatibilityPyramid bool `json:"elidedInCompatabilityPyramid"`
 
 	key string
 }
@@ -86,8 +87,8 @@ func main() {
 		if m.ReportsUnnecessary {
 			buf.WriteString(`, reportsUnnecessary: true`)
 		}
-		if m.ElidedInCompatabilityPyramid {
-			buf.WriteString(`, elidedInCompatabilityPyramid: true`)
+		if m.ElidedInCompatibilityPyramid {
+			buf.WriteString(`, elidedInCompatibilityPyramid: true`)
 		}
 		if m.ReportsDeprecated {
 			buf.WriteString(`, reportsDeprecated: true`)
diff --git a/internal/compiler/program.go b/internal/compiler/program.go
@@ -256,7 +256,7 @@ func getModuleNames(file *ast.SourceFile) []*ast.Node {
 }
 
 func (p *Program) GetSyntacticDiagnostics(sourceFile *ast.SourceFile) []*ast.Diagnostic {
-	return p.getDiagnosticsHelper(sourceFile, false /*ensureBound*/, false /*ensureChecked*/, p.getSyntaticDiagnosticsForFile)
+	return p.getDiagnosticsHelper(sourceFile, false /*ensureBound*/, false /*ensureChecked*/, p.getSyntacticDiagnosticsForFile)
 }
 
 func (p *Program) GetBindDiagnostics(sourceFile *ast.SourceFile) []*ast.Diagnostic {
@@ -288,7 +288,7 @@ func (p *Program) getOptionsDiagnosticsOfConfigFile() []*ast.Diagnostic {
 	return p.configFileParsingDiagnostics // TODO: actually call getDiagnosticsHelper on config path
 }
 
-func (p *Program) getSyntaticDiagnosticsForFile(sourceFile *ast.SourceFile) []*ast.Diagnostic {
+func (p *Program) getSyntacticDiagnosticsForFile(sourceFile *ast.SourceFile) []*ast.Diagnostic {
 	return sourceFile.Diagnostics()
 }
 
diff --git a/internal/jsnum/jsnum_test.go b/internal/jsnum/jsnum_test.go
@@ -115,8 +115,8 @@ func TestBitwiseNOT(t *testing.T) {
 	}{
 		{-2147483649, Number(2147483647).BitwiseNOT()},
 		{-4294967296, Number(0).BitwiseNOT()},
-		{-2147483648, Number(-2147483648).BitwiseNOT()},
-		{-4294967296, Number(0).BitwiseNOT()},
+		{2147483648, Number(-2147483648).BitwiseNOT()},
+		{4294967296, Number(0).BitwiseNOT()},
 	}
 
 	for _, test := range tests {
diff --git a/internal/printer/namegenerator_test.go b/internal/printer/namegenerator_test.go
@@ -188,6 +188,7 @@ func TestUniqueName2(t *testing.T) {
 	text2 := g.GenerateName(name1)
 
 	assert.Equal(t, "foo_1", text1)
+	// Expected to be same because GenerateName goes off object identity
 	assert.Equal(t, "foo_1", text2)
 }
 
diff --git a/internal/printer/printer.go b/internal/printer/printer.go
@@ -241,7 +241,7 @@ func (p *Printer) writeAs(text string, writeKind WriteKind) {
 	case WriteKindLiteral:
 		p.writeLiteral(text)
 	default:
-		panic(fmt.Sprintf("unexpected printer.WriteKind: %v", p.writeKind))
+		panic(fmt.Sprintf("unexpected printer.WriteKind: %v", writeKind))
 	}
 }
 
@@ -1818,7 +1818,7 @@ func (p *Printer) emitIndexedAccessType(node *ast.IndexedAccessTypeNode) {
 	p.exitNode(node.AsNode())
 }
 
-func (p *Printer) emitMappedTypeParamerter(node *ast.TypeParameterDeclaration) {
+func (p *Printer) emitMappedTypeParameter(node *ast.TypeParameterDeclaration) {
 	p.enterNode(node.AsNode())
 	p.emitBindingIdentifier(node.Name().AsIdentifier())
 	p.writeSpace()
@@ -1846,7 +1846,7 @@ func (p *Printer) emitMappedType(node *ast.MappedTypeNode) {
 		p.writeSpace()
 	}
 	p.writePunctuation("[")
-	p.emitMappedTypeParamerter(node.TypeParameter.AsTypeParameter())
+	p.emitMappedTypeParameter(node.TypeParameter.AsTypeParameter())
 	if node.NameType != nil {
 		p.writeSpace()
 		p.writeKeyword("as")
@@ -3260,10 +3260,10 @@ func (p *Printer) emitModuleDeclaration(node *ast.ModuleDeclaration) {
 	}
 	if body == nil {
 		p.writeTrailingSemicolon()
-		return
+	} else {
+		p.writeSpace()
+		p.emitModuleBlock(body.AsModuleBlock())
 	}
-	p.writeSpace()
-	p.emitModuleBlock(body.AsModuleBlock())
 	p.exitNode(node.AsNode())
 }
 
diff --git a/internal/scanner/scanner.go b/internal/scanner/scanner.go
@@ -1450,7 +1450,7 @@ func (s *Scanner) scanTemplateAndSetTokenValue(shouldEmitInvalidEscapeError bool
 		if ch == '\r' {
 			contents += s.text[start:s.pos]
 			s.pos++
-			if ch == '\n' {
+			if s.char() == '\n' {
 				s.pos++
 			}
 			contents += "\n"
diff --git a/internal/semver/version_range_test.go b/internal/semver/version_range_test.go
@@ -120,7 +120,7 @@ func TestVersionRanges(t *testing.T) {
 	lotsaOnes := strings.Repeat("1", 320)
 	assertRangesGoodBad(t, ">=1.2.3-1"+lotsaOnes, testGoodBad{
 		good: []string{"1.2.3-1" + lotsaOnes, "1.2.3-11" + lotsaOnes + ".1", "1.2.3-1" + lotsaOnes + ".1+build"},
-		bad:  []string{"1.2.3-" + lotsaOnes + ".1+build", "1.2.3-" + lotsaOnes + ".1+build"},
+		bad:  []string{"1.2.3-" + lotsaOnes + ".1+build"},
 	})
 }
 
@@ -858,8 +858,6 @@ func TestTildesOfVersionRanges(t *testing.T) {
 		{"~1", "1.0.0", true},
 		{"~1", "1.2.0", true},
 		{"~1", "1.2.3", true},
-		{"~1", "1.2.0", true},
-		{"~1", "1.2.3", true},
 		{"~1", "0.0.0", false},
 		{"~1", "2.0.0", false},
 		{"~1.2", "1.2.0", true},
diff --git a/internal/testutil/runner/compiler_runner.go b/internal/testutil/runner/compiler_runner.go
@@ -49,19 +49,19 @@ func (t *CompilerTestType) String() string {
 }
 
 type CompilerBaselineRunner struct {
-	testFiles    []string
-	basePath     string
-	testSuitName string
+	testFiles     []string
+	basePath      string
+	testSuiteName string
 }
 
 var _ Runner = (*CompilerBaselineRunner)(nil)
 
 func NewCompilerBaselineRunner(testType CompilerTestType) *CompilerBaselineRunner {
-	testSuitName := testType.String()
-	basePath := "tests/cases/" + testSuitName
+	testSuiteName := testType.String()
+	basePath := "tests/cases/" + testSuiteName
 	return &CompilerBaselineRunner{
-		basePath:     basePath,
-		testSuitName: testSuitName,
+		basePath:      basePath,
+		testSuiteName: testSuiteName,
 	}
 }
 
@@ -131,8 +131,8 @@ func (r *CompilerBaselineRunner) runSingleConfigTest(t *testing.T, test *compile
 	payload := makeUnitsFromTest(test.content, test.filename)
 	compilerTest := newCompilerTest(t, test.filename, &payload, config)
 
-	compilerTest.verifyDiagnostics(t, r.testSuitName)
-	compilerTest.verifyTypesAndSymbols(t, r.testSuitName)
+	compilerTest.verifyDiagnostics(t, r.testSuiteName)
+	compilerTest.verifyTypesAndSymbols(t, r.testSuiteName)
 	// !!! Verify all baselines
 }
 
diff --git a/internal/testutil/tsbaseline/util.go b/internal/testutil/tsbaseline/util.go
@@ -44,6 +44,7 @@ func isBuiltFile(filePath string) bool {
 }
 
 func isTsConfigFile(path string) bool {
+	// !!! fix to check for just prefixes/suffixes
 	return strings.Contains(path, "tsconfig") && strings.Contains(path, "json")
 }
 
diff --git a/internal/tsoptions/commandlineoption.go b/internal/tsoptions/commandlineoption.go
@@ -112,7 +112,7 @@ var commandLineOptionElements = map[string]*CommandLineOption{
 		Kind: CommandLineOptionTypeString,
 	},
 	"moduleSuffixes": {
-		Name: "suffix",
+		Name: "moduleSuffixes",
 		Kind: CommandLineOptionTypeString,
 	},
 	"customConditions": {
diff --git a/internal/tsoptions/commandlineparser.go b/internal/tsoptions/commandlineparser.go
@@ -109,7 +109,7 @@ func (p *commandLineParser) parseStrings(args []string) {
 
 func getInputOptionName(input string) string {
 	// removes at most two leading '-' from the input string
-	return strings.ToLower(strings.TrimLeft(strings.TrimLeft(input, "-"), "-"))
+	return strings.ToLower(strings.TrimPrefix(strings.TrimPrefix(input, "-"), "-"))
 }
 
 func (p *commandLineParser) parseResponseFile(fileName string) {
diff --git a/internal/tsoptions/tsconfigparsing.go b/internal/tsoptions/tsconfigparsing.go
@@ -796,7 +796,7 @@ func parseOwnConfigOfJson(
 	// watchOptions := convertWatchOptionsFromJsonWorker(json.watchOptions, basePath, errors)
 	// json.compileOnSave = convertCompileOnSaveOptionFromJson(json, basePath, errors)
 	var extendedConfigPath []string
-	if json["extends"] != nil || json["extends"] == "" {
+	if json["extends"] != nil && json["extends"] != "" {
 		extendedConfigPath, err = getExtendsConfigPathOrArray(json["extends"], host, basePath, configFileName, nil, nil, nil)
 		errors = append(errors, err...)
 	}
@@ -1207,8 +1207,8 @@ func canJsonReportNoInputFiles(rawConfig map[string]any) bool {
 	return !filesExists && !referencesExists
 }
 
-func shouldReportNoInputFiles(fileNames []string, canJsonReportNoInutFiles bool, resolutionStack []tspath.Path) bool {
-	return len(fileNames) == 0 && canJsonReportNoInutFiles && len(resolutionStack) == 0
+func shouldReportNoInputFiles(fileNames []string, canJsonReportNoInputFiles bool, resolutionStack []tspath.Path) bool {
+	return len(fileNames) == 0 && canJsonReportNoInputFiles && len(resolutionStack) == 0
 }
 
 func validateSpecs(specs any, disallowTrailingRecursion bool, jsonSourceFile *ast.SourceFile, specKey string) ([]string, []*ast.Diagnostic) {
diff --git a/internal/tsoptions/utilities.go b/internal/tsoptions/utilities.go
@@ -285,7 +285,7 @@ func getBasePaths(path string, includes []string, useCaseSensitiveFileNames bool
 				absolute = tspath.NormalizePath(tspath.CombinePaths(path, include))
 			}
 			// Append the literal and canonical candidate base paths.
-			includeBasePaths = []string{getIncludeBasePath(absolute)}
+			includeBasePaths = append(includeBasePaths, getIncludeBasePath(absolute))
 		}
 
 		// Sort the offsets array using either the literal or canonical path representations.

Original file line number	Diff line number	Diff line change
`@@ -356,7 +356,7 @@ func (n Node) TypeParameterList() NodeList {`
`356`	`356`	`return funcLike.TypeParameters`
`357`	`357`	`}`
`358`	`358`	`}`
`359`		`- panic("Unhandled case in Node.TypeParameters")`
	`359`	`+ panic("Unhandled case in Node.TypeParameterList")`
`360`	`360`	`}`
`361`	`361`
`362`	`362`	`func (n Node) TypeParameters() []Node {`
`@@ -382,7 +382,7 @@ func (n Node) MemberList() NodeList {`
`382`	`382`	`case KindMappedType:`
`383`	`383`	`return n.AsMappedTypeNode().Members`
`384`	`384`	`}`
`385`		`- panic("Unhandled case in Node.Members")`
	`385`	`+ panic("Unhandled case in Node.MemberList")`
`386`	`386`	`}`
`387`	`387`
`388`	`388`	`func (n Node) Members() []Node {`
`@@ -7596,12 +7596,12 @@ type Pragma struct {`
`7596`	`7596`	`type PragmaKindFlags = uint8`
`7597`	`7597`
`7598`	`7598`	`const (`
`7599`		`- PragmaKindFlagsNone PragmaKindFlags = iota`
`7600`		`- PragmaKindTripleSlashXML`
	`7599`	`+ PragmaKindTripleSlashXML PragmaKindFlags = 1 << iota`
`7601`	`7600`	`PragmaKindSingleLine`
`7602`	`7601`	`PragmaKindMultiLine`
`7603`		`- PragmaKindAll = PragmaKindTripleSlashXML \| PragmaKindSingleLine \| PragmaKindMultiLine`
`7604`		`- PragmaKindDefault = PragmaKindAll`
	`7602`	`+ PragmaKindFlagsNone PragmaKindFlags = 0`
	`7603`	`+ PragmaKindAll = PragmaKindTripleSlashXML \| PragmaKindSingleLine \| PragmaKindMultiLine`
	`7604`	`+ PragmaKindDefault = PragmaKindAll`
`7605`	`7605`	`)`
`7606`	`7606`
`7607`	`7607`	`type PragmaArgumentSpecification struct {`
Original file line number	Diff line number	Diff line change
`@@ -402,7 +402,7 @@ func (c *Checker) checkTypeRelatedToEx(`
`402`	`402`	`}`
`403`	`403`
`404`	`404`	`func createDiagnosticChainFromErrorChain(chain ErrorChain, errorNode ast.Node, relatedInfo []ast.Diagnostic) ast.Diagnostic {`
`405`		`- for chain != nil && chain.message.ElidedInCompatabilityPyramid() {`
	`405`	`+ for chain != nil && chain.message.ElidedInCompatibilityPyramid() {`
`406`	`406`	`chain = chain.next`
`407`	`407`	`}`
`408`	`408`	`if chain == nil {`
Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ func getModuleNames(file ast.SourceFile) []ast.Node {`
`256`	`256`	`}`
`257`	`257`
`258`	`258`	`func (p Program) GetSyntacticDiagnostics(sourceFile ast.SourceFile) []*ast.Diagnostic {`
`259`		`- return p.getDiagnosticsHelper(sourceFile, false /ensureBound/, false /ensureChecked/, p.getSyntaticDiagnosticsForFile)`
	`259`	`+ return p.getDiagnosticsHelper(sourceFile, false /ensureBound/, false /ensureChecked/, p.getSyntacticDiagnosticsForFile)`
`260`	`260`	`}`
`261`	`261`
`262`	`262`	`func (p Program) GetBindDiagnostics(sourceFile ast.SourceFile) []*ast.Diagnostic {`
`@@ -288,7 +288,7 @@ func (p Program) getOptionsDiagnosticsOfConfigFile() []ast.Diagnostic {`
`288`	`288`	`return p.configFileParsingDiagnostics // TODO: actually call getDiagnosticsHelper on config path`
`289`	`289`	`}`
`290`	`290`
`291`		`-func (p Program) getSyntaticDiagnosticsForFile(sourceFile ast.SourceFile) []*ast.Diagnostic {`
	`291`	`+func (p Program) getSyntacticDiagnosticsForFile(sourceFile ast.SourceFile) []*ast.Diagnostic {`
`292`	`292`	`return sourceFile.Diagnostics()`
`293`	`293`	`}`
`294`	`294`
Original file line number	Diff line number	Diff line change
`@@ -188,6 +188,7 @@ func TestUniqueName2(t *testing.T) {`
`188`	`188`	`text2 := g.GenerateName(name1)`
`189`	`189`
`190`	`190`	`assert.Equal(t, "foo_1", text1)`
	`191`	`+ // Expected to be same because GenerateName goes off object identity`
`191`	`192`	`assert.Equal(t, "foo_1", text2)`
`192`	`193`	`}`
`193`	`194`