Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facade conflict? #279

Closed
harrisoftware opened this issue Apr 14, 2015 · 4 comments
Closed

Facade conflict? #279

harrisoftware opened this issue Apr 14, 2015 · 4 comments

Comments

@harrisoftware
Copy link

ErrorException in FormBuilder.php line 82:
Argument 1 passed to Illuminate\Html\FormBuilder::construct() must be an instance of Illuminate\Html\HtmlBuilder, instance of Collective\Html\HtmlBuilder given, called in /Users/*_/Sites//vendor/patricktalmadge/bootstrapper/src/Bootstrapper/BootstrapperL5ServiceProvider.php on line 210 and defined (View: /Users/**/Sites/**_*/resources/views/admin/forms/fromModel.blade.php)

I'm guessing this is a conflict between bootstrapper and the HTML package from LaravelCollective which both use a Form Facade???

I'm new to this tho so I could be wrong. Any suggestions?

@PatrickRose
Copy link
Collaborator

I see the issue but I can't fix for a while.

Basically we expect an instance of Laravel's HTML component but you have something else bound instead (which is why people should prefix their IoC bindings, but that's a rant for another day).

I'll take a look at their code and see whether I can add a compatibility fix.

@harrisoftware
Copy link
Author

Well, until you fix it, i have changed the alias for the laravelcollective's restoration of the HTML and Form functionality of Laravel 4 Facade to 'FORM' from 'Form', so now I can use FORM and your Form in the same form - best of both world's (so far)

@PatrickRose
Copy link
Collaborator

Sorry for the delay on this - I've finally had a spare day to work on things.

I need to know more about how the Collective is working and what the plan is and when I checked a month ago I didn't find much about what the aim actually is.

EDIT: Hmmm. I see a quick fix.

EDIT 2: That fix is not a good fix. Gragh.

laravelcollective/html depends on illuminate/routing: ~5 or something similar meaning that I can't continue supporting laravel 4 and laravel 5 at the same time. So, unless there's something that laravelcollective/html provides that I'm unaware of I'll have to mark them as a conflict. I might open an issue to ask them to prefix their bindings.

@FabryB
Copy link

FabryB commented Aug 26, 2015

Please checkout my prposed fix, should work for everyone
#294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants