Add support for context #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instantiating them outside of their context (before it's parent has initialized it or not inside of parent).
…ment tag definitions) to facilitate testing of context.
…hadow DOM rendering, ensuring components are rendered/initialized from the top down (at least in light DOM, WIP for shadow).
…re querySelectorAll() for compatibility across both light DOM and shadow DOM (since that always returns document order, per spec). Cleaning up some console logs and debug code.
…te-retag-render', as it's only necessary for render. Cleans final rendered HTML (leaves no extra attribs behind).
…up unnecessary mutex/semaphor for requestAnimationFrame. Refactoring queueForRender() for simplicity and reducing redundancy there, too.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ll need to optimize heavily (without breaking context).
patricknelson
force-pushed
the
issue-10-context-support
branch
from
629420c to
bcde3ae
Compare
patricknelson
force-pushed
the
issue-10-context-support
branch
from
bcde3ae to
6db283f
Compare
patricknelson
force-pushed
the
issue-10-context-support
branch
from
1da95fa to
384b678
Compare
patricknelson
force-pushed
the
issue-10-context-support
branch
from
384b678 to
d70a244
Compare
…an up color vars for consistency.
…nt re-instantiating every component.
…ng of element attributes to component props without having to instantiate it any extra times (which not only can break context but also is likely unexpected in many situations). So, 1.) We can pass case-sensitive props at FIRST instantiation and then 2.) Retain them for mapping back if/when attributeChangedCallback() is called later.
…to ensure immediate results. Also ensuring we wrap with <svelte-retag> for now in Shadow DOM tests instead of <div>; it was replaced since it potentially adds extra formatting that we may not want.
…mock that ensures each queued callback runs to completion AND runs in sequential order (i.e. preventing nesting). Found quirk after first unit test made for validating context that couldn't be resolved (parent didn't complete initialization before child attempted to render).
This was referenced Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10 by implementing context support at the custom element level. Also, supersedes #12 since
requestAnimationFrame()is already part of the implementation. 😎Tasks:
requestAnimationFrame())