Destroy socket on client close#250
Conversation
|
We can actually use Rationale for using destroy: The docs say .end half closes the socket and .destroy will release any internal resources. I tried it with just a .destroy and checked the FTP logs to see what happens. I still get the following: It seems the connection is still closed gracefully? Therefore I think it is safe to use .destroy. (I've also tested if this works when closing a client and then using access to re-establish the connecting again, I had no issues there) |
|
I've also added a prepare command. In this way I can install my fork without having to publish it. Based on this answer: |
|
Thanks for this! I agree, let's go with For future PRs: Try to limit your PR to exactly the described issue. You've included some other things. I'll make an exception and merge them as well, but try to avoid that next time/elsewhere. |
Fixes: #249