Create tests for registering a user

Author: patrick-emmanuel

src/main/java/com/springboilerplate/springboilerplate/controller/PasswordResetTokenController.java

@@ -29,7 +29,7 @@ public ResponseEntity<?> resetPassword() throws Exception{
 
     //If successfully validated, then the user can update his password.
     @PostMapping(value = "/validateToken")
-    public ResponseEntity<Boolean> validateUserPassword(@RequestParam("id") long userId,
+    public ResponseEntity<Boolean> validateUserPassword(@RequestParam("userId") long userId,
                                                         @RequestParam("token") String token) {
         boolean valid = passwordResetTokenService.validateResetToken(userId, token);
         return new ResponseEntity<>(valid, HttpStatus.OK);

src/test/java/com/springboilerplate/springboilerplate/controller/BaseControllerTest.java

@@ -0,0 +1,41 @@
+package com.springboilerplate.springboilerplate.controller;
+
+import com.springboilerplate.springboilerplate.SpringBoilerplateApplication;
+import org.junit.runner.RunWith;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.http.MediaType;
+import org.springframework.http.converter.HttpMessageConverter;
+import org.springframework.http.converter.json.MappingJackson2HttpMessageConverter;
+import org.springframework.test.context.junit4.SpringRunner;
+import org.springframework.test.context.web.WebAppConfiguration;
+import org.springframework.transaction.annotation.Transactional;
+
+import java.nio.charset.Charset;
+import java.util.Arrays;
+
+import static org.junit.Assert.assertNotNull;
+
+@RunWith(SpringRunner.class)
+@SpringBootTest(classes = SpringBoilerplateApplication.class)
+@WebAppConfiguration
+@Transactional
+public class BaseControllerTest {
+
+    protected MediaType contentType = new MediaType(MediaType.APPLICATION_JSON.getType(),
+            MediaType.APPLICATION_JSON.getSubtype(),
+            Charset.forName("utf8"));
+
+    protected HttpMessageConverter mappingJackson2HttpMessageConverter;
+
+    @Autowired
+    protected void setConverters(HttpMessageConverter<?>[] converters) {
+        this.mappingJackson2HttpMessageConverter = Arrays.asList(converters).stream()
+                .filter(hmc -> hmc instanceof MappingJackson2HttpMessageConverter)
+                .findAny()
+                .orElse(null);
+
+        assertNotNull("the JSON message converter must not be null",
+                this.mappingJackson2HttpMessageConverter);
+    }
+}

src/test/java/com/springboilerplate/springboilerplate/controller/LoginTest.java

@@ -29,11 +29,7 @@
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
 import static org.springframework.test.web.servlet.setup.MockMvcBuilders.webAppContextSetup;
 
-@RunWith(SpringRunner.class)
-@SpringBootTest
-@WebAppConfiguration
-@Transactional
-public class LoginTest {
+public class LoginTest extends BaseControllerTest{
     @Autowired
     private FilterChainProxy springSecurityFilter;
     @Autowired
@@ -42,24 +38,8 @@ public class LoginTest {
     private UserRepository userRepository;
     private User user;
 
-    private MediaType contentType = new MediaType(MediaType.APPLICATION_JSON.getType(),
-            MediaType.APPLICATION_JSON.getSubtype(),
-            Charset.forName("utf8"));
-
     private MockMvc mockMvc;
 
-    private HttpMessageConverter mappingJackson2HttpMessageConverter;
-
-    @Autowired
-    private void setConverters(HttpMessageConverter<?>[] converters) {
-        this.mappingJackson2HttpMessageConverter = Arrays.asList(converters).stream()
-                .filter(hmc -> hmc instanceof MappingJackson2HttpMessageConverter)
-                .findAny()
-                .orElse(null);
-
-        assertNotNull("the JSON message converter must not be null",
-                this.mappingJackson2HttpMessageConverter);
-    }
     @Before
     @Rollback
     public void setup() throws Exception {
@@ -79,5 +59,17 @@ public void loginUser() throws Exception {
                 .andReturn().getResponse()
                 .getHeader("authorization");
         assertNotNull(authHeader);
+
+        //Access a protected resource to ensure that the jwt authentication is working.
+        mockMvc.perform(get("/v1/users/hello")
+                .header("authorization", authHeader))
+                .andExpect(status().isOk());
+    }
+
+    @Test
+    @Rollback
+    public void accessingAProtectedResourceShouldReturn403UnAuthorized() throws Exception {
+        mockMvc.perform(get("/v1/users/hello"))
+                .andExpect(status().isForbidden());
     }
 }

src/test/java/com/springboilerplate/springboilerplate/controller/UserControllerTest.java

@@ -0,0 +1,41 @@
+package com.springboilerplate.springboilerplate.controller;
+
+import com.springboilerplate.springboilerplate.dto.UserDto;
+import com.springboilerplate.springboilerplate.stubs.UserStubs;
+import com.springboilerplate.springboilerplate.utils.JsonUtils;
+import org.junit.Before;
+import org.junit.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.test.annotation.Rollback;
+import org.springframework.test.web.servlet.MockMvc;
+import org.springframework.test.web.servlet.setup.MockMvcBuilders;
+import org.springframework.web.context.WebApplicationContext;
+
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
+import static org.springframework.test.web.servlet.result.MockMvcResultHandlers.print;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
+
+public class UserControllerTest extends BaseControllerTest{
+
+    private MockMvc mockMvc;
+    @Autowired
+    private WebApplicationContext webApplicationContext;
+
+    private UserDto userDto;
+
+    @Before
+    public void setUp() throws Exception {
+        this.mockMvc = MockMvcBuilders.webAppContextSetup(webApplicationContext).build();
+        userDto = UserStubs.generateUserDto();
+    }
+
+    @Test
+    @Rollback
+    public void registerUser() throws Exception {
+        this.mockMvc.perform(post("/v1/users/register")
+                .content(JsonUtils.json(userDto, mappingJackson2HttpMessageConverter))
+                .contentType(contentType))
+                .andDo(print())
+                .andExpect(status().isCreated());
+    }
+}

src/test/java/com/springboilerplate/springboilerplate/mocks/UserMocks.java

@@ -1,17 +1,24 @@
 package com.springboilerplate.springboilerplate.mocks;
 
+import com.springboilerplate.springboilerplate.dto.UserDto;
+import com.springboilerplate.springboilerplate.enums.RoleType;
 import com.springboilerplate.springboilerplate.model.User;
 import com.springboilerplate.springboilerplate.repository.UserRepository;
+import com.springboilerplate.springboilerplate.service.UserService;
 import com.springboilerplate.springboilerplate.stubs.PasswordResetTokenStubs;
 import com.springboilerplate.springboilerplate.stubs.UserStubs;
 
 import static org.mockito.Matchers.any;
 import static org.mockito.Matchers.anyString;
+import static org.mockito.Mockito.doNothing;
 import static org.mockito.Mockito.when;
 
 public class UserMocks {
     public void initMocks(UserRepository userRepository){
         when(userRepository.save(any(User.class))).thenReturn(UserStubs.generateUser());
         when(userRepository.getByEmailAndDeletedFalse(anyString())).thenReturn(UserStubs.generateOptionalUser());
     }
+    public void initUserServiceMocks(UserService userService){
+        when(doNothing().when(userService).saveUser(any(UserDto.class), any(RoleType.class)));
+    }
 }

src/test/java/com/springboilerplate/springboilerplate/stubs/UserStubs.java

@@ -27,7 +27,7 @@ public static Optional<User> generateOptionalUser(){
     }
     public static UserDto generateUserDto(){
         return new UserDto("Patrick", "Emmanuel",
-                "Password", "email@email.com");
+                "email@email.com", "Password");
     }
 
     public static User generateUserWithNoRole(){