query interface test for delayed jobs. #18

Author: yigit

jobqueue/src/com/path/android/jobqueue/JobManager.java

@@ -308,6 +308,10 @@ private void reAddJob(JobHolder jobHolder) {
      * <p>
      *     You should not call this method on UI thread because it may make a db request.
      * </p>
+     * <p>
+     *     This is not a very fast call so try not to make it unless necessary. Consider using events if you need to be
+     *     informed about a job's lifecycle.
+     * </p>
      * @param id the ID, returned by the addJob method
      * @param isPersistent Jobs are added to different queues depending on if they are persistent or not. This is necessary
      *                     because each queue has independent id sets.

jobqueue/test/com/path/android/jobqueue/test/jobmanager/AddInBackgroundTest.java

@@ -1,8 +1,14 @@
 package com.path.android.jobqueue.test.jobmanager;
 
+import com.path.android.jobqueue.AsyncAddCallback;
+import com.path.android.jobqueue.BaseJob;
 import com.path.android.jobqueue.Job;
+import com.path.android.jobqueue.JobHolder;
+import com.path.android.jobqueue.JobManager;
+import com.path.android.jobqueue.JobQueue;
 import com.path.android.jobqueue.Params;
 import com.path.android.jobqueue.test.jobs.DummyJob;
+import org.fest.reflect.core.*;
 import org.hamcrest.*;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -14,15 +20,19 @@
 @RunWith(RobolectricTestRunner.class)
 public class AddInBackgroundTest extends JobManagerTestBase {
     @Test
-    public void testAddInBackground() {
-        addInBackground(false);
-        addInBackground(true);
-
+    public void testAddInBackground() throws InterruptedException {
+        for(boolean delay : new boolean[]{true, false}) {
+            for(boolean useCallback : new boolean[]{true, false}) {
+                addInBackground(delay, useCallback);
+            }
+        }
     }
-    public void addInBackground(boolean delayed) {
+
+    public void addInBackground(boolean delayed, boolean useCallback) throws InterruptedException {
         long currentThreadId = Thread.currentThread().getId();
         final AtomicLong onAddedThreadId = new AtomicLong();
         final CountDownLatch addedLatch = new CountDownLatch(2);
+
         Job dummyJob = new DummyJob(new Params(1).setDelayMs(delayed ? 1000 : 0)) {
             @Override
             public void onAdded() {
@@ -31,9 +41,33 @@ public void onAdded() {
                 addedLatch.countDown();
             }
         };
-        createJobManager().addJobInBackground(dummyJob);
-
-        addedLatch.countDown();
+        JobManager jobManager = createJobManager();
+        jobManager.stop();
+        final AtomicLong jobId = new AtomicLong(0);
+        if(useCallback) {
+            jobManager.addJobInBackground(dummyJob, new AsyncAddCallback() {
+                @Override
+                public void onAdded(long id) {
+                    jobId.set(id);
+                    addedLatch.countDown();
+                }
+            });
+        } else {
+            addedLatch.countDown();
+            jobManager.addJobInBackground(dummyJob);
+        }
+        addedLatch.await();
         MatcherAssert.assertThat("thread ids should be different. delayed:" + delayed, currentThreadId, CoreMatchers.not(onAddedThreadId.get()));
+        if(useCallback) {
+            JobQueue queue = getNonPersistentQueue(jobManager);
+            JobHolder holder = queue.findJobById(jobId.longValue());
+            MatcherAssert.assertThat("there should be a job in the holder. id:" + jobId.longValue() +", delayed:" + delayed + ", use cb:" + useCallback
+                    , holder, CoreMatchers.notNullValue());
+            MatcherAssert.assertThat("id callback should have the proper id:", holder.getBaseJob(), CoreMatchers.is((BaseJob) dummyJob));
+        }
+    }
+
+    protected JobQueue getNonPersistentQueue(JobManager jobManager) {
+        return Reflection.field("nonPersistentJobQueue").ofType(JobQueue.class).in(jobManager).get();
     }
 }